fix: the old custom wallpaper homescreen image was set to black#396
fix: the old custom wallpaper homescreen image was set to black#396guowei0105 merged 4 commits intoOneKeyHQ:mainfrom
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
WalkthroughThe PR updates the firmware patch version, refactors wallpaper replacement logic to return a boolean status, introduces dynamic page sizing and bounce animation in AppDrawer, adds a device label synchronization utility function, and changes the default wallpaper asset. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to data retention organization setting
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (5)
core/embed/firmware/version.h(1 hunks)core/src/trezor/lvglui/scrs/homescreen.py(13 hunks)core/src/trezor/lvglui/scrs/nftmanager.py(5 hunks)core/src/trezor/lvglui/scrs/preview_utils.py(2 hunks)core/src/trezor/utils.py(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Gen check
- GitHub Check: Defs check
- GitHub Check: Style check
🔇 Additional comments (5)
core/embed/firmware/version.h (1)
13-13: Verify version bump is appropriate.PR title indicates bug fix, but AI summary mentions new features (bounce animation, dynamic page sizing). Patch versions are for bug fixes only; features need minor version bump.
core/src/trezor/utils.py (1)
344-344: LGTM.Fixes the reported black wallpaper issue.
core/src/trezor/lvglui/scrs/preview_utils.py (1)
99-136: LGTM.Function logic is sound. Handles edge cases properly.
core/src/trezor/lvglui/scrs/nftmanager.py (2)
591-612: LGTM.Label setup is correct. Full width enables proper centering.
638-641: LGTM.Keeps labels synced with current settings.
Summary by CodeRabbit
New Features
Bug Fixes
Chores