Skip to content

[Snyk] Security upgrade requests from 2.31.0 to 2.33.0 #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
revan-zhang wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Snyk] Security upgrade requests from 2.31.0 to 2.33.0 #420

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions python/requirements-optional.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@ hidapi >= 0.7.99.post20
web3 >= 4.8
Pillow
stellar-sdk>=4.0.0,<6.0.0
requests>=2.33.0 # not directly required, pinned by Snyk to avoid a vulnerability
Copy link
Copy Markdown

@cursor cursor bot Mar 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security fix placed in wrong requirements file

Medium Severity

The requests package is a direct dependency declared in python/requirements.txt (with >=2.4.0) and used as install_requires in setup.py. Pinning requests>=2.33.0 in requirements-optional.txt — which is only consumed by the full tox environment — leaves the actual install path unprotected. Standard installations via pip install or setup.py will still resolve requests>=2.4.0, meaning the vulnerability (SNYK-PYTHON-REQUESTS-15763443) remains exploitable for most users. The comment "not directly required" is also incorrect.

Fix in Cursor Fix in Web

Copy link
Copy Markdown

@cursor cursor bot Mar 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requests 2.33.0 breaks supported Python versions

Medium Severity

requests 2.33.0 dropped support for Python 3.9 and requires Python 3.10+. This project declares python_requires=">=3.6" in setup.py and tests py{36,37,38,39,310} variants in tox. When the full tox environment installs requirements-optional.txt, pip will fail to resolve dependencies on Python 3.6–3.9 because no requests version satisfies both >=2.33.0 and Python <3.10.

Fix in Cursor Fix in Web

Loading