-
Notifications
You must be signed in to change notification settings - Fork 60
feat(core): allow priority fee related instruction in transaction #588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe change introduces a new constant named Changes
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (2)
core/src/apps/solana/constents.py(1 hunks)core/src/apps/solana/sign_tx.py(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (5)
- GitHub Check: Gen check
- GitHub Check: Defs check
- GitHub Check: Style check
- GitHub Check: Analyze (python)
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (3)
core/src/apps/solana/constents.py (1)
41-42: Good addition of Compute Budget Program ID.Clean implementation with proper docstring. This aligns with PR objective of supporting priority fee instructions.
core/src/apps/solana/sign_tx.py (2)
23-23: Import added correctly.Import follows the existing style pattern.
35-35: Properly added to allowed programs list.This addition means transactions with Compute Budget Program ID won't require blind signing.
Summary by CodeRabbit
New Features
Documentation