Conversation
WalkthroughThis update bumps version numbers from 1.0.35 to 1.0.36-alpha.1 across multiple packages. It also updates internal dependency versions to match. One package switches its main entry point to a minified build. No code, API, or public interface changes are present—only metadata and dependency adjustments. Changes
Sequence Diagram(s)No sequence diagram is necessary for these metadata and dependency version updates. ✨ Finishing Touches🧪 Generate Unit Tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (12)
packages/connect-examples/electron-example/package.json(1 hunks)packages/connect-examples/expo-example/package.json(2 hunks)packages/core/package.json(2 hunks)packages/hd-ble-sdk/package.json(2 hunks)packages/hd-common-connect-sdk/package.json(2 hunks)packages/hd-transport-http/package.json(2 hunks)packages/hd-transport-lowlevel/package.json(2 hunks)packages/hd-transport-react-native/package.json(2 hunks)packages/hd-transport-webusb/package.json(2 hunks)packages/hd-transport/package.json(1 hunks)packages/hd-web-sdk/package.json(2 hunks)packages/shared/package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (5)
- GitHub Check: build (18.x)
- GitHub Check: lint (18.x)
- GitHub Check: Socket Security: Pull Request Alerts
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: Analyze (actions)
🔇 Additional comments (17)
packages/connect-examples/electron-example/package.json (1)
5-5: Version bump acknowledgedNo issues found. Thanks for keeping the example in sync.
packages/hd-transport/package.json (1)
3-3: Sync lock-file before releaseAfter changing the version, re-run the package manager to refresh the lock file. This prevents mismatched installs.
packages/core/package.json (1)
3-3: Let's check dependency versions across all workspaces:#!/bin/bash # Search for hd-shared dependency versions in all package.json files rg -H -n '"@onekeyfe/hd-shared":' -g '*.json' # Search for hd-transport dependency versions in all package.json files rg -H -n '"@onekeyfe/hd-transport":' -g '*.json'packages/hd-transport-webusb/package.json (1)
3-3: WebUSB package in syncVersion and internal deps line up with the rest of the bump. Looks good.
Also applies to: 23-24
packages/hd-transport-lowlevel/package.json (2)
3-3: Version bump looks good
Bumping to 1.0.36 keeps the package in lock-step with the monorepo.
22-24: Deps bumped in sync – nice
Internal dependencies now use^1.0.36, matching this package. No further action.packages/hd-transport-http/package.json (2)
3-3: Package version aligned
1.0.36 tag is consistent with the fleet.
27-28: Internal deps updated correctly
hd-sharedandhd-transportboth point to ^1.0.36. Looks good.packages/hd-ble-sdk/package.json (2)
3-3: Version bump accepted
1.0.36 keeps everything consistent.
23-25: Dependency matrix stays in sync
Core, shared, and RN transport all updated to ^1.0.36. 👍packages/connect-examples/expo-example/package.json (2)
3-3: Example app version updated
Good to see the example tracking the SDK version.
22-25: SDK refs updated
All four OneKey packages now target ^1.0.36 – consistent with the rest of the repo.packages/hd-transport-react-native/package.json (2)
3-3: RN transport version bump OK
1.0.36 aligns with sibling packages.
22-23: Deps bumped in tandem
hd-sharedandhd-transportmoved to ^1.0.36. Looks good.packages/hd-common-connect-sdk/package.json (2)
3-3: Version bump looks good.1.0.36 lines up with the rest of the repo.
23-27: Lock-file and changelog check.Run
yarn install(ornpm install) and commit the regenerated lock-file, and add an entry to your CHANGELOG.packages/hd-web-sdk/package.json (1)
24-27: Sync lock-file and CI cache.Bump the lock-file so CI and consumers pull
^1.0.36consistently.
packages/shared/package.json
Outdated
| { | ||
| "name": "@onekeyfe/hd-shared", | ||
| "version": "1.0.35", | ||
| "version": "1.0.36", |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Add CHANGELOG entry for 1.0.36
Bump looks fine, but the repo lacks a note that explains what changed in 1.0.36. Add a line to the changelog before publishing.
🤖 Prompt for AI Agents
In packages/shared/package.json at line 3, the version has been bumped to 1.0.36
but there is no corresponding entry in the changelog. Add a new entry to the
changelog file describing the changes introduced in version 1.0.36 before
publishing the package.
| "license": "ISC", | ||
| "type": "commonjs", | ||
| "main": "build/onekey-js-sdk.js", | ||
| "main": "build/onekey-js-sdk.min.js", |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Minified file as “main” may hurt debug-ability.
Exposing the minified bundle as main will give users obfuscated stack traces. Consider:
- "main": "build/onekey-js-sdk.min.js",
+ "main": "build/onekey-js-sdk.js",
+ "browser": "build/onekey-js-sdk.min.js",Ship source maps if you choose to keep the minified entry.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "main": "build/onekey-js-sdk.min.js", | |
| "main": "build/onekey-js-sdk.js", | |
| "browser": "build/onekey-js-sdk.min.js", |
🤖 Prompt for AI Agents
In packages/hd-web-sdk/package.json at line 8, the "main" field points to the
minified bundle which reduces debug-ability due to obfuscated stack traces. To
fix this, either change the "main" entry to point to the unminified build file
or ensure that source maps are generated and shipped alongside the minified file
to enable proper debugging.
ByteZhang1024
force-pushed
the
feat/optimizeCode
branch
from
0232387 to
3c637e4
Compare
There was a problem hiding this comment.
Actionable comments posted: 5
♻️ Duplicate comments (2)
packages/shared/package.json (1)
3-3: CHANGELOG reminder already raised earlierSame note as the last review: add an entry for 1.0.36-alpha.1.
packages/hd-web-sdk/package.json (1)
8-8: Minified bundle set asmain– same concern as last roundPointing
mainto the minified build will still give users obfuscated stack traces. Either expose the un-minified file asmainand keep the minified one underbrowser, or ship reliable source-maps.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (12)
packages/connect-examples/electron-example/package.json(1 hunks)packages/connect-examples/expo-example/package.json(2 hunks)packages/core/package.json(2 hunks)packages/hd-ble-sdk/package.json(2 hunks)packages/hd-common-connect-sdk/package.json(2 hunks)packages/hd-transport-http/package.json(2 hunks)packages/hd-transport-lowlevel/package.json(2 hunks)packages/hd-transport-react-native/package.json(2 hunks)packages/hd-transport-webusb/package.json(2 hunks)packages/hd-transport/package.json(1 hunks)packages/hd-web-sdk/package.json(2 hunks)packages/shared/package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: build (18.x)
- GitHub Check: lint (18.x)
- GitHub Check: Analyze (actions)
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (11)
packages/connect-examples/electron-example/package.json (1)
5-5: Let’s list every version string in all package.json files to be sure:#!/bin/bash # Count unique version entries across all package.json rg -o '"version": "[^"]*"' -g 'package.json' \ | sed -E 's/"version": "([^"]*)"/\1/' \ | sort \ | uniq -cpackages/hd-transport-lowlevel/package.json (1)
3-3: Confirm caret-range works with pre-releases
^1.0.36-alpha.1is allowed, but some tooling mis-resolves pre-release ranges. Please run an install in each supported package manager (npm, pnpm, yarn) to ensure no version drift.You can script a quick check:
#!/bin/bash set -e for m in npm pnpm yarn; do echo "Testing with $m" $m --version || continue rm -rf node_modules && $m install --silent doneAlso applies to: 22-24
packages/hd-transport-http/package.json (1)
3-3: Same caret-range cautionRepeat the install check here to catch any mismatch early.
Also applies to: 27-28
packages/hd-transport-webusb/package.json (1)
3-3: Same caret-range cautionVerify the prerelease caret resolves as expected across toolchains.
Also applies to: 23-24
packages/core/package.json (1)
3-3: Guard against accidental stable-upgrade by dropping^for pre-release.
^1.0.36-alpha.1lets npm jump to the first stable1.xonce published (e.g.,1.1.0). That may pull in breaking changes before you’re ready. Pin the exact alpha or switch to~.- "@onekeyfe/hd-shared": "^1.0.36-alpha.1", - "@onekeyfe/hd-transport": "^1.0.36-alpha.1", + "@onekeyfe/hd-shared": "1.0.36-alpha.1", + "@onekeyfe/hd-transport": "1.0.36-alpha.1",packages/connect-examples/expo-example/package.json (2)
3-3: Example app version looks fine.Only metadata changed; no action needed.
22-25: Consider exact pins for alpha deps.Same risk as core package—
^will float to stable unexpectedly. Lock or tilde-pin if the example must track the alpha series.packages/hd-ble-sdk/package.json (1)
3-3: Version bump acknowledged.No issues spotted.
packages/hd-transport-react-native/package.json (1)
3-3: Metadata update accepted.Looks good.
packages/hd-common-connect-sdk/package.json (1)
3-3: Package version bump is consistent.No issues here.
packages/hd-web-sdk/package.json (1)
24-27: Caret on pre-release locks you out of stable 1.0.36Using
^1.0.36-alpha.1pins you to alpha builds only; npm will not upgrade to1.0.36once it lands. If the intention is to stick with this exact tag, drop the caret for clarity. If you want the first stable ≥ 1.0.36, remove the pre-release suffix instead.Example fix:
- "@onekeyfe/hd-core": "^1.0.36-alpha.1", - "@onekeyfe/hd-shared": "^1.0.36-alpha.1", - "@onekeyfe/hd-transport-http": "^1.0.36-alpha.1", - "@onekeyfe/hd-transport-webusb": "^1.0.36-alpha.1" + "@onekeyfe/hd-core": "1.0.36-alpha.1", + "@onekeyfe/hd-shared": "1.0.36-alpha.1", + "@onekeyfe/hd-transport-http": "1.0.36-alpha.1", + "@onekeyfe/hd-transport-webusb": "1.0.36-alpha.1"Double-check the desired upgrade path before publishing.
| { | ||
| "name": "@onekeyfe/hd-transport", | ||
| "version": "1.0.35", | ||
| "version": "1.0.36-alpha.1", |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Add a matching CHANGELOG note for 1.0.36-alpha.1
The bump is fine, but users will look for release notes. Drop a one-liner in the changelog before publishing.
🤖 Prompt for AI Agents
In packages/hd-transport/package.json at line 3, the version has been bumped to
1.0.36-alpha.1 but there is no corresponding entry in the CHANGELOG file. Add a
one-line note describing the changes or purpose of this release in the CHANGELOG
file before publishing to provide users with release information.
| "@onekeyfe/hd-shared": "^1.0.36-alpha.1", | ||
| "@onekeyfe/hd-transport": "^1.0.36-alpha.1", |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Mirror the bump in peerDependencies.
Users embedding this lib may hit a mismatch warning. Add the same 1.0.36-alpha.1 range to peerDependencies or drop peers if no longer needed.
🤖 Prompt for AI Agents
In packages/core/package.json around lines 28 to 29, the versions of
@onekeyfe/hd-shared and @onekeyfe/hd-transport have been updated in dependencies
but not in peerDependencies. To avoid version mismatch warnings for users,
update the peerDependencies section to include the same version range
"^1.0.36-alpha.1" for these packages, or remove them from peerDependencies if
they are no longer required.
| "@onekeyfe/hd-core": "^1.0.36-alpha.1", | ||
| "@onekeyfe/hd-shared": "^1.0.36-alpha.1", | ||
| "@onekeyfe/hd-transport-react-native": "^1.0.36-alpha.1" | ||
| } |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Pin alpha dependencies.
Replicate the advice from hd-core—drop the caret to avoid surprise upgrades.
🤖 Prompt for AI Agents
In packages/hd-ble-sdk/package.json around lines 23 to 26, the alpha
dependencies use caret (^) version ranges which can lead to unexpected upgrades.
Remove the caret (^) from the version strings of "@onekeyfe/hd-core",
"@onekeyfe/hd-shared", and "@onekeyfe/hd-transport-react-native" to pin them to
exact versions, matching the approach used in hd-core.
| "@onekeyfe/hd-shared": "^1.0.36-alpha.1", | ||
| "@onekeyfe/hd-transport": "^1.0.36-alpha.1", |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Lock down alpha versions.
Use exact versions for @onekeyfe/hd-shared and @onekeyfe/hd-transport or be ready for automatic jumps.
🤖 Prompt for AI Agents
In packages/hd-transport-react-native/package.json at lines 22 to 23, the
dependencies for @onekeyfe/hd-shared and @onekeyfe/hd-transport use caret (^)
version ranges which allow automatic updates to newer minor or patch versions.
To lock down alpha versions and prevent unintended automatic version jumps,
replace the version strings with exact versions by removing the caret prefix,
specifying the exact version numbers instead.
| "@onekeyfe/hd-core": "^1.0.36-alpha.1", | ||
| "@onekeyfe/hd-shared": "^1.0.36-alpha.1", | ||
| "@onekeyfe/hd-transport-http": "^1.0.36-alpha.1", | ||
| "@onekeyfe/hd-transport-lowlevel": "^1.0.36-alpha.1", | ||
| "@onekeyfe/hd-transport-webusb": "^1.0.36-alpha.1" |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Prevent unintended upgrades from alpha to stable.
Swap ^1.0.36-alpha.1 for an exact version or ~ across these deps.
🤖 Prompt for AI Agents
In packages/hd-common-connect-sdk/package.json around lines 23 to 27, the
dependencies use caret (^) version specifiers with alpha versions, which can
unintentionally upgrade to stable releases. Replace the caret (^) with either
exact version numbers or tilde (~) to restrict upgrades to patch versions within
the alpha release, preventing unintended upgrades to stable versions.
1 participant
Summary by CodeRabbit