Skip to content

Conversation

@ByteZhang1024
Copy link
Contributor

@ByteZhang1024 ByteZhang1024 commented Sep 18, 2025

Summary by CodeRabbit

  • Chores

    • Updated default Connect SDK source to version 1.1.13, ensuring users get the latest improvements and fixes by default.
    • Environment variable override remains supported; no configuration changes required.
  • Bug Fixes

    • Improves stability and compatibility by defaulting to the latest SDK build.
  • Documentation

    • No user-facing behavior changes beyond default SDK version; no migration needed.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 18, 2025

Walkthrough

Updated the default Connect SDK URL in getConnectSrc from version 1.1.11 to 1.1.13. The environment variable override (CONNECT_SRC) remains unchanged.

Changes

Cohort / File(s) Summary of changes
Connect examples constants
packages/connect-examples/shared-constants/constants.js
Bumped fallback URL in getConnectSrc from https://jssdk.onekey.so/1.1.11/ to https://jssdk.onekey.so/1.1.13/; no signature or behavior changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "chore: update version" clearly indicates a version bump and matches the changeset that updates the default connect SDK URL from v1.1.11 to v1.1.13; it is concise and on-topic for a chore. It effectively signals the primary intent of the PR to reviewers. It is somewhat generic, however, and could be more informative by specifying the package or new version.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/updateJssdk

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Comment @coderabbitai help to get the list of available commands and usage tips.

@revan-zhang
Copy link
Contributor

revan-zhang commented Sep 18, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 7eaf493 and b523fe7.

📒 Files selected for processing (1)
  • packages/connect-examples/shared-constants/constants.js (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: lint (22)
  • GitHub Check: build (22)
  • GitHub Check: build_new_example
  • GitHub Check: build_expo

@wabicai wabicai merged commit eb7dd28 into onekey Sep 18, 2025
13 checks passed
@wabicai wabicai deleted the chore/updateJssdk branch September 18, 2025 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants