fix: gitignore #2
Conversation
WalkthroughThis pull request makes several updates across the repository. The Changes
Sequence Diagram(s)sequenceDiagram
participant JS as React Native JS
participant Module as BleUtilsModule
participant BTAdapter as Bluetooth Adapter
participant Receiver as MyBroadcastReceiver
JS->>Module: checkState(callback)
Module->>BTAdapter: Query adapter state
BTAdapter-->>Module: Return state info
Module->>JS: Return state via callback
note over Receiver, Module: On bond state change
Receiver-->>Module: Notify bond change
Module->>JS: emitOnDeviceBondState(event)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (6)
.gitignore(1 hunks)android/src/main/java/so/onekey/lib/ble/utils/BleUtilsModule.kt(1 hunks)android/src/main/java/so/onekey/lib/ble/utils/BleUtilsPackage.kt(1 hunks)android/src/main/java/so/onekey/lib/ble/utils/data/Peripheral.kt(1 hunks)package.json(5 hunks)tsconfig.build.json(1 hunks)
🔇 Additional comments (10)
tsconfig.build.json (1)
3-3: Exclude list updated to reflect new output directory.
The"exclude"property now omits the"dist"folder instead of"lib", which aligns with the updated build output..gitignore (1)
79-79: Gitignore updated: Ignoring the "dist" folder.
The entry now ignoresdist/instead oflib/, which is consistent with the recent changes in the build output and package settings.package.json (6)
3-9: Package metadata updated to reflect new outputs.
The version is bumped to0.1.1and paths formain,module, andtypesnow point to thedistdirectory. This change ensures consistency with the new build structure.
10-12: Files array updated to include "dist".
Adding the"dist"directory ensures that the build output is properly packaged for distribution.
33-34: Clean script modified to target the correct output folder.
Thecleanscript now removes thedistdirectory instead oflib, which prevents stale build artifacts from affecting new builds.
91-93: Jest module path ignore updated.
The"modulePathIgnorePatterns"now excludes<rootDir>/dist/, ensuring that Jest ignores build output files during tests.
138-140: ESLint ignore configuration adjusted.
By updating the ignore pattern from"lib/"to"dist/", ESLint now correctly skips linting the build output folder.
149-151: React Native Builder Bob output altered.
The"output"field is now set to"dist", which completes the transition fromlibtodistacross the project configuration.android/src/main/java/so/onekey/lib/ble/utils/BleUtilsPackage.kt (1)
9-17: Clean and straightforward package implementation.
You only export a single module and skip view managers. This is typical and efficient.android/src/main/java/so/onekey/lib/ble/utils/data/Peripheral.kt (1)
25-27: Clarify connectability.
You hardcodetruefor"isConnectable". That might mislead if the device lacks connectable attributes.
Summary by CodeRabbit
New Features
Chores