Skip to content

Conversation

Randoooom
Copy link
Collaborator

@Randoooom Randoooom commented Jul 11, 2025

Closes #142

image

Copy link

gitguardian bot commented Jul 11, 2025

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
18451295 Triggered Generic Private Key f3c4a65 tests/_common/configs/key.pem View secret
18451296 Triggered Generic Private Key f3c4a65 tests/_common/configs/indexer/key.pem View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@Randoooom
Copy link
Collaborator Author

The detected secrets by gitguardian are dummy mTLS certificates and therefore fine being committed, will investigate how i can ignore them in gitguardian

Copy link

codecov bot commented Jul 12, 2025

Codecov Report

❌ Patch coverage is 82.57805% with 173 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.24%. Comparing base (baabe1b) to head (e3ca897).

Files with missing lines Patch % Lines
src/broker/mod.rs 81.94% 26 Missing ⚠️
src/broker/producer.rs 65.00% 21 Missing ⚠️
src/database/schema/authorization.rs 42.42% 19 Missing ⚠️
indexer/src/processor/mod.rs 65.11% 15 Missing ⚠️
src/database/schema/feedback/field.rs 71.15% 15 Missing ⚠️
indexer/src/processor/index.rs 88.57% 12 Missing ⚠️
src/database/schema/feedback/prompt.rs 52.00% 12 Missing ⚠️
indexer/src/broker/grpc.rs 88.73% 8 Missing ⚠️
indexer/src/config.rs 46.66% 8 Missing ⚠️
indexer/src/broker/fluvio.rs 83.72% 7 Missing ⚠️
... and 12 more
@@            Coverage Diff             @@
##             main     #170      +/-   ##
==========================================
+ Coverage   79.55%   82.24%   +2.68%     
==========================================
  Files          26       41      +15     
  Lines        2583     3508     +925     
==========================================
+ Hits         2055     2885     +830     
- Misses        528      623      +95     
Files with missing lines Coverage Δ
codegen/src/lib.rs 91.60% <ø> (ø)
common/src/database/schema/audit.rs 100.00% <100.00%> (ø)
common/src/database/schema/user.rs 100.00% <100.00%> (ø)
common/src/observability/otlp.rs 57.40% <100.00%> (ø)
src/broker/consumer.rs 100.00% <100.00%> (ø)
src/cache.rs 62.80% <ø> (+7.85%) ⬆️
src/config.rs 92.06% <100.00%> (+0.46%) ⬆️
src/error.rs 50.00% <ø> (+8.82%) ⬆️
src/main.rs 97.36% <100.00%> (-0.14%) ⬇️
src/services/v1/audit.rs 100.00% <100.00%> (ø)
... and 28 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Randoooom
Copy link
Collaborator Author

Current state:

image

We're now able to also render the audit versions in the dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make resources auditable

1 participant