-
-
Notifications
You must be signed in to change notification settings - Fork 0
Add sound page #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sound page #51
Conversation
aecc1d4 to
e46d238
Compare
# Conflicts: # lib/api/api_service.dart
…ocol specification from Minecraft
17e470b to
a296c34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a comprehensive sound event management feature, including UI components, state management, API integration, and test coverage for a new text input formatter.
- Adds
SoundPagewith tabs for general settings and file entries management - Implements
MinValueFormatterfor enforcing minimum integer values in text fields - Creates modal dialogs and widgets for managing sound file sources with volume, pitch, weight, and attenuation controls
Reviewed Changes
Copilot reviewed 38 out of 39 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/util/formatter/min_value_fomatter.dart | New text input formatter that enforces minimum integer values and removes leading zeros |
| lib/feature/sound/sound_page.dart | Main sound event page with paginated list and tabbed interface |
| lib/feature/sound/sound_general_page.dart | Form for editing sound event properties (name, key, subtitle) |
| lib/feature/sound/sound_file_entries.dart | Paginated list view for sound file sources with create/delete functionality |
| lib/feature/sound/modal/*.dart | Modal dialogs and sections for editing sound file properties |
| lib/feature/sound/card/*.dart | Card components for displaying sound files |
| lib/api/state/app_state.dart | Added soundEvents and selectedSoundEvent to app state |
| lib/api/state/actions/sound/*.dart | Redux actions for sound event and file CRUD operations |
| lib/api/service/client/sound_client_api.dart | HTTP client for sound event API endpoints |
| lib/api/model/sound/*.dart | Data models for SoundEventModel and SoundFileSource |
| test/util.formatter/*.dart | Unit and integration tests for MinValueFormatter |
| test/feature/sound/card/folder_icon_unit_test.dart | Tests for FolderIcon widget |
Comments suppressed due to low confidence (2)
lib/feature/sound/modal/sound_file_modal.dart:1
- Debug message has a typo: 'Exsts' should be 'Exists'.
import 'package:flutter/material.dart';
lib/feature/sound/modal/sound_file_modal.dart:1
- Debug print statements should be removed from production code. These appear to be leftover debugging code.
import 'package:flutter/material.dart';
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Proposed changes
This pull request adds the required widget structure and code logic to manage the lifecycle of custom sound definitions. It comes with some limitations, such as no support for multiple deletions and an unpolished interface. These will be fixed in the near future.
Types of changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any ofthem, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.