Skip to content

Conversation

@theEvilReaper
Copy link
Collaborator

@theEvilReaper theEvilReaper commented Oct 17, 2025

Proposed changes

This pull request adds the required widget structure and code logic to manage the lifecycle of custom sound definitions. It comes with some limitations, such as no support for multiple deletions and an unpolished interface. These will be fixed in the near future.

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING.md
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@theEvilReaper theEvilReaper self-assigned this Nov 5, 2025
@theEvilReaper theEvilReaper marked this pull request as ready for review November 5, 2025 15:13
@theEvilReaper theEvilReaper requested a review from Copilot November 5, 2025 15:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a comprehensive sound event management feature, including UI components, state management, API integration, and test coverage for a new text input formatter.

  • Adds SoundPage with tabs for general settings and file entries management
  • Implements MinValueFormatter for enforcing minimum integer values in text fields
  • Creates modal dialogs and widgets for managing sound file sources with volume, pitch, weight, and attenuation controls

Reviewed Changes

Copilot reviewed 38 out of 39 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
lib/util/formatter/min_value_fomatter.dart New text input formatter that enforces minimum integer values and removes leading zeros
lib/feature/sound/sound_page.dart Main sound event page with paginated list and tabbed interface
lib/feature/sound/sound_general_page.dart Form for editing sound event properties (name, key, subtitle)
lib/feature/sound/sound_file_entries.dart Paginated list view for sound file sources with create/delete functionality
lib/feature/sound/modal/*.dart Modal dialogs and sections for editing sound file properties
lib/feature/sound/card/*.dart Card components for displaying sound files
lib/api/state/app_state.dart Added soundEvents and selectedSoundEvent to app state
lib/api/state/actions/sound/*.dart Redux actions for sound event and file CRUD operations
lib/api/service/client/sound_client_api.dart HTTP client for sound event API endpoints
lib/api/model/sound/*.dart Data models for SoundEventModel and SoundFileSource
test/util.formatter/*.dart Unit and integration tests for MinValueFormatter
test/feature/sound/card/folder_icon_unit_test.dart Tests for FolderIcon widget
Comments suppressed due to low confidence (2)

lib/feature/sound/modal/sound_file_modal.dart:1

  • Debug message has a typo: 'Exsts' should be 'Exists'.
import 'package:flutter/material.dart';

lib/feature/sound/modal/sound_file_modal.dart:1

  • Debug print statements should be removed from production code. These appear to be leftover debugging code.
import 'package:flutter/material.dart';

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@theEvilReaper theEvilReaper merged commit 2a68553 into develop Nov 5, 2025
3 checks passed
@theEvilReaper theEvilReaper deleted the feature/sound_v2 branch November 5, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants