Skip to content

Better implementation of closest(line, line) function #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Better implementation of closest(line, line) function #72

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c151f7
Implement closest(line, line) function
ajesquirell Feb 17, 2024
4bb7fca
Merge branch 'OneLoneCoder:main' into closest-line-line
ajesquirell Feb 19, 2024
6266efb
Merge branch 'OneLoneCoder:main' into closest-line-line
ajesquirell Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 32 additions & 2 deletions olcUTIL_Geometry2D.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -899,8 +899,38 @@ namespace olc::utils::geom2d
template<typename T1, typename T2>
inline olc::v_2d<T1> closest(const line<T1>& l1, const line<T2>& l2)
{
// TODO:
return {};
std::vector<olc::v_2d<T1>> intersections = intersects(l2, l1);
if (!intersections.empty()) {
return intersections[0];
}

olc::v_2d<T1> v1 = closest(l1, l2.start);
olc::v_2d<T1> v2 = closest(l1, l2.end);
olc::v_2d<T2> v3 = closest(l2, l1.start);
olc::v_2d<T2> v4 = closest(l2, l1.end);

T1 d1 = (v1 - l2.start).mag2();
T1 d2 = (v2 - l2.end).mag2();
T2 d3 = (v3 - l1.start).mag2();
T2 d4 = (v4 - l1.end).mag2();

double min = d1;
olc::v_2d<T1>& vClosest = v1;

if (d2 < min) {
min = d2;
vClosest = v2;
}
if (d3 < min) {
min = d3;
vClosest = l1.start;
}
if (d4 < min) {
min = d4;
vClosest = l1.end;
}

return vClosest;
}

// closest(r,l)
Expand Down