Skip to content

fix: send receive receipt even when preventDefault is called #2512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nan-li merged 2 commits into from
Jan 7, 2026
Merged

fix: send receive receipt even when preventDefault is called #2512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
846d925
fix: send receive receipt even when preventDefault is called
nan-li Jan 2, 2026
3f7dcd0
Also track influence and firebase analytics
nan-li Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...a/com/onesignal/notifications/internal/generation/impl/NotificationGenerationProcessor.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,9 +233,9 @@ internal class NotificationGenerationProcessor(
// Notification channel disable or not displayed
// save notification as dismissed to avoid user re-enabling channel and notification being displayed due to restore
markNotificationAsDismissed(notificationJob)
return
}

// Always call notificationReceived, regardless of wasDisplayed
_lifecycleService.notificationReceived(notificationJob)
}

Expand Down
8 changes: 8 additions & 0 deletions ...a/com/onesignal/notifications/internal/generation/NotificationGenerationProcessorTests.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,10 @@ class NotificationGenerationProcessorTests : FunSpec({
mocks.notificationGenerationProcessor.processNotificationData(mocks.context, 1, mocks.notificationPayload, false, 1111)

// Then
// notificationReceived should be called
coVerify(exactly = 1) {
mocks.notificationLifecycleService.notificationReceived(any())
}
}

test("processNotificationData should display notification when external callback takes longer than 30 seconds") {
Expand Down Expand Up @@ -209,6 +213,10 @@ class NotificationGenerationProcessorTests : FunSpec({
mocks.notificationGenerationProcessor.processNotificationData(mocks.context, 1, mocks.notificationPayload, false, 1111)

// Then
// notificationReceived should be called
coVerify(exactly = 1) {
mocks.notificationLifecycleService.notificationReceived(any())
}
}

test("processNotificationData should display notification when foreground callback takes longer than 30 seconds") {
Expand Down