Skip to content

Conversation

@fadi-george
Copy link
Collaborator

@fadi-george fadi-george commented Nov 18, 2025

Description

One Line Summary

  • update ci workflow to use rps test command

Details

  • change ci step to use rps command to run the custom test script in pubspec
    • this runs flutter test coverage then checks total coverage meets threshold (80)

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

@fadi-george fadi-george requested a review from a team as a code owner November 18, 2025 20:23
@fadi-george fadi-george force-pushed the fg/ci-tests branch 3 times, most recently from 9c8b010 to 839bc16 Compare November 18, 2025 22:00
@fadi-george fadi-george force-pushed the fg/tests3 branch 2 times, most recently from 64aa52a to 321f195 Compare November 18, 2025 22:39
@fadi-george fadi-george changed the title ci: update ci workflow to use rps test: update ci workflow to use rps Nov 19, 2025
@fadi-george fadi-george changed the title test: update ci workflow to use rps ci: update ci workflow to use rps Nov 19, 2025
Base automatically changed from fg/tests3 to main November 19, 2025 23:07
@fadi-george fadi-george merged commit dde9f62 into main Nov 19, 2025
2 checks passed
@fadi-george fadi-george deleted the fg/ci-tests branch November 19, 2025 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants