-
Notifications
You must be signed in to change notification settings - Fork 233
feat: add swift package manager support #1104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
2d5c9a6 to
55bd06e
Compare
996291b to
dc61d1b
Compare
dc61d1b to
8e86c1b
Compare
8e86c1b to
755b480
Compare
4090cbb to
763875f
Compare
nan-li
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Duplicate source files in
ios/Classes/andios/onesignal_flutter/Sources/onesignal_flutter/. Step 8 and 9 of guide notes to remove old directory:
Move all files from ios/Classes to ios/plugin_name/Sources/plugin_name.
The ios/Assets, ios/Resources, and ios/Classes directories should now be empty and can be deleted.
- Info on documentation steps needed? This is the existing Flutter SDK setup: https://documentation.onesignal.com/docs/en/flutter-sdk-setup. Can you add any notes on how we would update the docs?
75bac60 to
6d44027
Compare
6d44027 to
e3d723c
Compare
26bf451 to
3fc7238
Compare
|
Seems like for NSE and live activity widget they both need to manually add OneSignalXCFramework to "Frameworks and Libraries" section |
Description
One Line Summary
Adds swift package manager support for the flutter sdk package.
Details
Closes #971
Follows https://docs.flutter.dev/packages-and-plugins/swift-package-manager/for-plugin-authors#how-to-turn-on-swift-package-manager guide for setting up spm for flutter plugins.
Motivation
Testing
Manual testing
Test step 20 for https://docs.flutter.dev/packages-and-plugins/swift-package-manager/for-plugin-authors#how-to-turn-on-swift-package-manager
where I disabled spm config and did
flutter runin the example projectThen I re-enabled spm config and did the same thing and it still worked.
Pods:
Show pod install

SPM:
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is