Skip to content

Conversation

@shepherd-l
Copy link
Contributor

@shepherd-l shepherd-l commented Nov 5, 2024

Description

One Line Summary

Update version numbers of the included native OneSignal SDKs.

Details

Motivation

Applies fixes from the OneSignal Android SDK and OneSignal iOS SDK to the Unity SDK.

Scope

  • Updates included Android SDK from 5.1.21 to 5.1.24
    • Pausing in-app messages now dismisses any currently displaying in-app messages
    • Fix setting consentGiven throwing if called before initWithContext
    • Fix BadTokenException and WindowLeaked exception caused by showing a dialog on a finishing or destroyed activity
    • For full changes, see the native release notes
  • Updates included iOS SDK from 5.2.4 to 5.2.7
    • Pausing in-app messages now dismisses any currently displaying in-app messages
    • Don't use cached in-app messages if the SDK encounters an error fetching them or when the server returns none
    • Improve segment membership calculation that allows for fetching more accurate and updated in-app messages for a user
    • For full changes, see the native release notes

Testing

Manual testing

Tested OneSignal initialization, app build with Unity 2022.3.10f1 of the OneSignal example app on a emulated Pixel 4 with Android 12 and physical iPhone 12 with iOS 17.5.1.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

@shepherd-l shepherd-l requested a review from jkasten2 November 5, 2024 21:56
@shepherd-l shepherd-l merged commit e0eb433 into main Nov 5, 2024
1 check passed
@shepherd-l shepherd-l deleted the updateNativeOneSignalSDKs branch November 5, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants