test: increase code coverage pt 2 #1411

sherwinski · 2025-11-27T03:08:52Z

Description

1 Line Summary

Adds more tests to increase code coverage.

Details

Adds/expands test across the following modules:

Bell
PromptsManager
CustomLinkManager
ServiceWorkerManager
UpdateManager
SessionManager

Before

 Test Files  52 passed (52)
      Tests  395 passed (395)
   Start at  19:08:24
   Duration  24.31s

 % Coverage report from v8

=============================== Coverage summary ===============================
Statements   : 67.52% ( 3817/5653 )
Branches     : 54.86% ( 1619/2951 )
Functions    : 75.44% ( 925/1226 )
Lines        : 67.69% ( 3697/5461 )
================================================================================

After

 Test Files  55 passed (55)
      Tests  411 passed (411)
   Start at  11:22:18
   Duration  32.88s

 % Coverage report from v8

=============================== Coverage summary ===============================
Statements   : 71.23% ( 4027/5653 )
Branches     : 59.26% ( 1749/2951 )
Functions    : 77.07% ( 945/1226 )
Lines        : 71.47% ( 3903/5461 )
================================================================================

Systems Affected

WebSDK
Backend
Dashboard

Validation

Tests

Info

Checklist

All the automated tests pass or I explained why that is not possible
I have personally tested this on my machine or explained why that is not possible
I have included test coverage for these changes or explained why they are not needed

Programming Checklist
Interfaces:

Don't use default export
New interfaces are in model files

Functions:

Don't use default export
All function signatures have return types
Helpers should not access any data but rather be given the data to operate on.

Typescript:

No Typescript warnings
Avoid silencing null/undefined warnings with the exclamation point

Other:

Iteration: refrain from using elem of array syntax. Prefer forEach or use map
Avoid using global OneSignal accessor for context if possible. Instead, we can pass it to function/constructor so that we don't call OneSignal.context

Screenshots

Info

Checklist

I have included screenshots/recordings of the intended results or explained why they are not needed

Related Tickets

This change is

…OnBlur

- disabled config and stylesheet failure return - hiding containers when subscribed and `unsubscribeEnable: false` - injecting markup and click flow (optIn then optOut) with text and class checks

- Different cases where `_getActiveState` returns None, OneSignal, or Third-Party sw - `_haveParamsChanged` branches (no registration, scope mismatch, missing scriptUrl, href changes, same href) - `_shoulInstallWorker` branches (SW support, OneSignal config, state, params changed, needs update) - `_workerNeedsUpdate` where comparing versions

- `_sendPushDeviceRecordUpdate` early return vs triggering `sendOnSessionUpdate` - `_sendOnSessionUpdate` branches: already sent, not first page, not registered, unsubscribed skip, subscribed path schedules upsert and sets flag

fadi-george · 2025-12-01T18:47:20Z

src/page/bell/Bell.test.ts

+    };
+    bell._setCustomColorsIfSpecified();
+    const background = document.querySelector<HTMLElement>('.background')!;
+    expect(background.getAttribute('style')).toContain('#111');


nit: add new lines after expects

fadi-george · 2025-12-01T18:52:07Z

src/page/managers/PromptsManager.test.ts

+    const nativeSpy = vi
+      .spyOn(pm, '_internalShowNativePrompt')
+      .mockResolvedValue(true);
+    const slidedownSpy = vi


could just make _internalShowSlidedownPrompt public since it gets mangled anyway
and remove the type assertions

fadi-george · 2025-12-01T19:03:01Z

src/page/managers/PromptsManager.test.ts

+    const pm = new PromptsManager(OneSignal._context);
+    const getOptsSpy = vi
+      .spyOn(
+        pm as unknown as {


same thing here

fadi-george · 2025-12-01T19:05:22Z

src/page/managers/PromptsManager.test.ts

+          pageViews: 0,
+        }),
+      );
+    const condSpy = vi


_isPageViewConditionMet can be separated out of this class since theres no this usage,

export function isPageViewConditionMet(options?: DelayedPromptOptions): boolean { if (!options || typeof options.pageViews === 'undefined') { return false; } if (!options.autoPrompt || !options.enabled) { return false; } const localPageViews = getLocalPageViewCount(); return localPageViews >= options.pageViews; }

Then it test can do:

import * as prompts from './PromptsManager'; const { PromptsManager } = prompts; ... const slidedownSpy = vi .spyOn(prompts, 'isPageViewConditionMet') .mockReturnValue(false);

fadi-george · 2025-12-01T19:22:24Z

src/shared/managers/sessionManager/SessionManager.test.ts

      TestEnvironment.initialize();
+      sm = new SessionManager(OneSignal._context);
+      notifySpy = vi.spyOn(sm, '_notifySWToUpsertSession');
+      deactSpy = vi


same thing, could make public

fadi-george · 2025-12-01T19:25:22Z

src/shared/managers/sessionManager/SessionManager.test.ts

+      // ensure user present
+      User._createOrGetInstance();
+
+      vi.spyOn(


Lets move function outside of the class _getOneSignalAndSubscriptionIds -> export function getOneSignalAndSubscriptionIds since theres no this usage

fadi-george · 2025-12-01T19:26:59Z

src/shared/managers/sessionManager/SessionManager.test.ts

+      visSpy.mockRestore();
+      focusSpy.mockRestore();


dont really need

fadi-george · 2025-12-01T19:27:54Z

src/shared/managers/CustomLinkManager.test.ts

+      OneSignal._context._dynamicResourceLoader,
+      '_loadSdkStylesheet',
+    ).mockResolvedValue(ResourceLoadState._Failed);
+    await mgr._initialize();


nit: new line after

fadi-george · 2025-12-01T19:29:06Z

src/shared/managers/UpdateManager.test.ts

+
+  test('_sendOnSessionUpdate flows: already sent, not first page, not registered, skip when unsubscribed, success path sets flag', async () => {
+    // Already sent
+    (mgr as unknown as { _onSessionSent: boolean })._onSessionSent = true;


avoid type assertions

could do this instead mgr['_onSessionSent'] = true;

fadi-george · 2025-12-01T19:32:28Z

src/shared/managers/UpdateManager.test.ts

+    (mgr as unknown as { _onSessionSent: boolean })._onSessionSent = true;
+    await mgr._sendOnSessionUpdate();
+    // reset
+    (mgr as unknown as { _onSessionSent: boolean })._onSessionSent = false;


mgr['_onSessionSent'] = false;

fadi-george · 2025-12-01T19:36:38Z

src/shared/managers/UpdateManager.test.ts

+
+    // Registered but not subscribed and enableOnSession not true -> skip
+    alreadySpy.mockResolvedValue(true);
+    const pushSpy = vi


could do:

const pushSub = createPushSub(); pushSub._notification_types = NotificationType._NoNativePermission; const pushSpy = vi .spyOn(OneSignal._coreDirector, '_getPushSubscriptionModel') .mockResolvedValue(pushSub);

fadi-george · 2025-12-01T19:38:11Z

src/shared/managers/UpdateManager.test.ts

+    expect(upsertSpy).not.toHaveBeenCalled();
+
+    // Subscribed path
+    pushSpy.mockResolvedValue({


pushSub._notification_types = NotificationType._Subscribed; pushSub.id = 'sub'; pushSpy.mockResolvedValue(pushSub); await mgr._sendOnSessionUpdate();

fadi-george · 2025-12-01T19:38:42Z

src/shared/managers/ServiceWorkerManager.test.ts

+      mgr as unknown as { _workerNeedsUpdate: () => Promise<boolean> },
+      '_workerNeedsUpdate',
+    ).mockResolvedValue(false);
+    await expect(


too much type assertion usages

fadi-george · 2025-12-01T19:39:40Z

src/shared/managers/ServiceWorkerManager.test.ts

+    await expect(
+      (
+        mgr as unknown as { _shouldInstallWorker: () => Promise<boolean> }
+      )._shouldInstallWorker(),
+    ).resolves.toBe(false);


could do this and similar things for the others:

await expect(mgr['_shouldInstallWorker']()).resolves.toBe(false);

fadi-george · 2025-12-01T19:41:59Z

src/shared/managers/ServiceWorkerManager.test.ts

+    vi.spyOn(mgr, '_getActiveState').mockResolvedValue(
+      helpers.ServiceWorkerActiveState._OneSignalWorker,
+    );
+    vi.spyOn(


could make _haveParamsChanged public since it just returns a boolean

sherwinski added 10 commits November 25, 2025 15:06

test(Bell): permission denied; set custom colors, add css to head

19dcc73

test(PromptsManager): show slidedown when user interaction required

708fe48

test(SessionManager): handle visibility changes; handleOnFocus/handle…

35ae9e9

…OnBlur

test(CustomLinkManager): add test coverage

19b983a

- disabled config and stylesheet failure return - hiding containers when subscribed and `unsubscribeEnable: false` - injecting markup and click flow (optIn then optOut) with text and class checks

test(UpdateManager): add test coverage

9d30e59

- `_sendPushDeviceRecordUpdate` early return vs triggering `sendOnSessionUpdate` - `_sendOnSessionUpdate` branches: already sent, not first page, not registered, unsubscribed skip, subscribed path schedules upsert and sets flag

test: fix build errors - first pass

c338604

test: clean up messy TS casts; remove use of any

0c34440

test: refactor to avoid redundant spies

264a025

test(SessionManager): remove use of any

ef50e18

sherwinski requested a review from fadi-george November 27, 2025 03:08

style: fix linter errors

c18a8b7

fadi-george reviewed Dec 1, 2025

View reviewed changes

test: increase code coverage pt 2 #1411

Are you sure you want to change the base?

test: increase code coverage pt 2 #1411

Conversation

sherwinski commented Nov 27, 2025 • edited by niels-s Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

1 Line Summary

Details

Before

After

Systems Affected

Validation

Tests

Info

Checklist

Screenshots

Info

Checklist

Related Tickets

Uh oh!

fadi-george Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fadi-george Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fadi-george Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fadi-george Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sherwinski commented Nov 27, 2025 •

edited by niels-s

Loading

fadi-george Dec 1, 2025 •

edited

Loading

fadi-george Dec 1, 2025 •

edited

Loading

fadi-george Dec 1, 2025 •

edited

Loading

fadi-george Dec 1, 2025 •

edited

Loading