Skip to content

chore: revert 3afbde99#1431

Merged
sherwinski merged 1 commit intomainfrom
revert/api/preventdefault-display-foregroundwilldisplay
Feb 27, 2026
Merged

chore: revert 3afbde99#1431
sherwinski merged 1 commit intomainfrom
revert/api/preventdefault-display-foregroundwilldisplay

Conversation

@sherwinski
Copy link
Contributor

@sherwinski sherwinski commented Feb 27, 2026

Description

1 Line Summary

The events key in api.json gets ignored by web shim. Instead, we need to update web shim's snippets to include event interfaces, see: OneSignal/web-shim-codegen#133

Details

Systems Affected

  • WebSDK
  • Backend
  • Dashboard

Validation

Tests

Info

Checklist

  • All the automated tests pass or I explained why that is not possible
  • I have personally tested this on my machine or explained why that is not possible
  • I have included test coverage for these changes or explained why they are not needed

Programming Checklist
Interfaces:

  • Don't use default export
  • New interfaces are in model files

Functions:

  • Don't use default export
  • All function signatures have return types
  • Helpers should not access any data but rather be given the data to operate on.

Typescript:

  • No Typescript warnings
  • Avoid silencing null/undefined warnings with the exclamation point

Other:

  • Iteration: refrain from using elem of array syntax. Prefer forEach or use map
  • Avoid using global OneSignal accessor for context if possible. Instead, we can pass it to function/constructor so that we don't call OneSignal.context

Screenshots

Info

Checklist

  • I have included screenshots/recordings of the intended results or explained why they are not needed

Related Tickets



This change is Reviewable

The "events" key in api.json gets ignored by web shim. Instead, we need to update web shim's snippets to include event interfaces, see: OneSignal/web-shim-codegen#133
@sherwinski sherwinski merged commit 01ab1ce into main Feb 27, 2026
5 checks passed
@sherwinski sherwinski deleted the revert/api/preventdefault-display-foregroundwilldisplay branch February 27, 2026 15:49
@github-actions github-actions bot mentioned this pull request Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants