fix: refactor and fix notify bell hover logic#1435
Merged
fadi-george merged 34 commits intomainfrom Mar 4, 2026
Merged
Conversation
abdulraqeeb33
left a comment
There was a problem hiding this comment.
Its a lot of changes @fadi-george . can we do a small bug bash around this?
abdulraqeeb33
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
1 Line Summary
Address: https://app.asana.com/1/780103692902078/project/1208777190614537/task/1213013500097033
Refactor and fix the notify bell component, resolving a tooltip race condition and simplifying CSS/JS.
Details
This overhauls the bell (notify button) prompt. Major areas of change:
AnimatedElementbase class and simplified all bell sub-components (Launcher, Button, Badge, Message, Dialog)_Hovering/_Hoveredevent handlers sharing a_hoveringflag. If_show()resolved before the_Hovered(mouse-leave) handler ran,_hoveringwas alreadyfalse, so the hide was never scheduled. This refactor removes that pattern entirely in favor of a simplemouseleavelistener that blurs the button.Screenshots/Videos
Hover / Click
Screen.Recording.2026-03-04.at.12.43.05.AM.mov
With tooltip hover
Regular
Positioned Right
Custom Colors
Systems Affected
Validation
Tests
Info
Added and expanded unit tests across all bell sub-components. Coverage thresholds configured in vitest.config.ts.
Checklist
Programming Checklist
Interfaces:
Functions:
Typescript:
Other:
elem of arraysyntax. PreferforEachor usemapcontextif possible. Instead, we can pass it to function/constructor so that we don't callOneSignal.contextScreenshots
Info
N/A - visual behavior validated manually via playground.
Checklist
Related Tickets
https://app.asana.com/1/780103692902078/project/1208777190614537/task/1213013500097033
This change is