fix: [SDK-4150] prevent prototype pollution in JSONP calls#1442
Merged
fadi-george merged 8 commits intomainfrom Mar 23, 2026
Merged
fix: [SDK-4150] prevent prototype pollution in JSONP calls#1442fadi-george merged 8 commits intomainfrom
fadi-george merged 8 commits intomainfrom
Conversation
Made-with: Cursor
sherwinski
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
1 Line Summary
Prevent prototype pollution exploitation in the
jsonpdependency by passing explicit options.Details
The
jsonplibrary readsprefix,name,param, andtimeoutfrom an options object using||fallbacks. When no explicit options are passed, these properties resolve via the prototype chain — allowing an attacker with a prototype pollution primitive to control the JSONP callback name and achieve arbitrary code execution.This fix passes explicit values for all
jsonpoptions so own properties shadow any pollutedObject.prototypevalues.Systems Affected
Validation
Tests
Info
Object.prototype.prefix = 'alert(1)//'no longer triggers an alertObject.prototype.name = 'alert(1)'no longer triggers an alertChecklist
Programming Checklist
Interfaces:
Functions:
Typescript:
Other:
elem of arraysyntax. PreferforEachor usemapcontextif possible. Instead, we can pass it to function/constructor so that we don't callOneSignal.contextScreenshots
Info
N/A — no UI changes.
Checklist
Related Tickets