chore: Migrate to Vite+ toolchain, fix all lint errors, and remove async from synchronous code#1445
Merged
fadi-george merged 8 commits intomainfrom Mar 24, 2026
Merged
chore: Migrate to Vite+ toolchain, fix all lint errors, and remove async from synchronous code#1445fadi-george merged 8 commits intomainfrom
fadi-george merged 8 commits intomainfrom
Conversation
sherwinski
approved these changes
Mar 23, 2026
Made-with: Cursor
e754684 to
8db4760
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
1 Line Summary
Migrate from Vite to Vite+ toolchain, resolve all lint/type errors, and remove unnecessary
asyncfrom synchronous functions.Details
vp) toolchain for building, testing, and linting. Consolidated test config into the main Vite config and replacedvite-tsconfig-pathswith builtin support.globals: truefrom vitest config and added explicitimport { vi, describe, test, expect, ... } from 'vite-plus/test'across all 64 test files, fixing type resolution issues withvp check.no-floating-promises: addedvoidfor fire-and-forget callsno-base-to-string/restrict-template-expressions: usedJSON.stringify(),String(),.toISOString()for proper serializationawait-thenable: removed unnecessaryawaiton non-Promise valuesunbound-method: used.bind(), extracted spy variables, restructured method accessno-redundant-type-constituents: simplified typesno-misused-spread: replaced class instance spread withObject.assign()require-awaitfixes: Removedasyncfrom functions that neverawait, or converted them to returnPromise.resolve()/Promise.reject()where callers depend on the Promise return type. Affected source files includePermissionManager,SessionManager,ServiceWorkerManager,SlidedownManager,WorkerMessengerPage,ServiceWorker,init.ts,listeners.ts, andpageSdkInit.ts.OneSignalDeferredLoadedCallbacktype update: Updated callback type from() => voidto() => void | PromiseLike<void>so thatawait OneSignal.push(item)works without wrapping inPromise.resolve().api.json: UpdatedsetConsentRequiredspec toisAsync: false/returnType: "void"to match the actual implementation.Systems Affected
Validation
Tests
Info
All 484 tests pass across 57 test files.
vp checkreports 0 errors and 0 warnings across 287 source files.Checklist
Programming Checklist
Interfaces:
Functions:
Typescript:
Other:
elem of arraysyntax. PreferforEachor usemapcontextif possible. Instead, we can pass it to function/constructor so that we don't callOneSignal.contextScreenshots
Info
No UI changes — this is a toolchain migration and lint cleanup.
Checklist
Related Tickets