Skip to content

Commit 3ef1dd1

Browse files
committed
adding OSInAppMessage public class with the messageId property
Using this new class in our IAM Lifecycle Handler Methods
1 parent 59cf17d commit 3ef1dd1

File tree

3 files changed

+13
-8
lines changed

3 files changed

+13
-8
lines changed

iOS_SDK/OneSignalSDK/Source/OSInAppMessageInternal.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,8 @@
3434

3535
NS_ASSUME_NONNULL_BEGIN
3636

37-
@interface OSInAppMessageInternal : NSObject <NSCoding, OSJSONDecodable, OSJSONEncodable>
37+
@interface OSInAppMessageInternal : OSInAppMessage <NSCoding, OSJSONDecodable, OSJSONEncodable>
3838

39-
@property (strong, nonatomic, nonnull) NSString *messageId;
4039
@property (strong, nonatomic, nonnull) NSDictionary<NSString *, NSDictionary <NSString *, NSString *> *> *variants;
4140
@property (strong, nonatomic, nonnull) NSArray<NSArray <OSTrigger *> *> *triggers;
4241

iOS_SDK/OneSignalSDK/Source/OSInAppMessageInternal.m

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@ - (NSUInteger)hash {
205205
}
206206

207207
- (void)encodeWithCoder:(NSCoder *)encoder {
208-
[encoder encodeObject:_messageId forKey:@"messageId"];
208+
[encoder encodeObject:self.messageId forKey:@"messageId"];
209209
[encoder encodeObject:_variants forKey:@"variants"];
210210
[encoder encodeObject:_triggers forKey:@"triggers"];
211211
[encoder encodeObject:_displayStats forKey:@"displayStats"];
@@ -217,7 +217,7 @@ - (void)encodeWithCoder:(NSCoder *)encoder {
217217

218218
- (id)initWithCoder:(NSCoder *)decoder {
219219
if (self = [super init]) {
220-
_messageId = [decoder decodeObjectForKey:@"messageId"];
220+
self.messageId = [decoder decodeObjectForKey:@"messageId"];
221221
_variants = [decoder decodeObjectForKey:@"variants"];
222222
_triggers = [decoder decodeObjectForKey:@"triggers"];
223223
_displayStats = [decoder decodeObjectForKey:@"displayStats"];

iOS_SDK/OneSignalSDK/Source/OneSignal.h

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -156,6 +156,12 @@ typedef NS_ENUM(NSUInteger, OSNotificationActionType) {
156156

157157
@end;
158158

159+
@interface OSInAppMessage : NSObject
160+
161+
@property (strong, nonatomic, nonnull) NSString *messageId;
162+
163+
@end
164+
159165
@interface OSInAppMessageOutcome : NSObject
160166

161167
@property (strong, nonatomic, nonnull) NSString *name;
@@ -208,10 +214,10 @@ typedef NS_ENUM(NSUInteger, OSNotificationActionType) {
208214
@protocol OSInAppMessageDelegate <NSObject>
209215
@optional
210216
- (void)handleMessageAction:(OSInAppMessageAction * _Nonnull)action NS_SWIFT_NAME(handleMessageAction(action:));
211-
- (void)onWillDisplayInAppMessage:(NSString *)message;
212-
- (void)onDidDisplayInAppMessage:(NSString *)message;
213-
- (void)onWillDismissInAppMessage:(NSString *)message;
214-
- (void)onDidDismissInAppMessage:(NSString *)message;
217+
- (void)onWillDisplayInAppMessage:(OSInAppMessage *)message;
218+
- (void)onDidDisplayInAppMessage:(OSInAppMessage *)message;
219+
- (void)onWillDismissInAppMessage:(OSInAppMessage *)message;
220+
- (void)onDidDismissInAppMessage:(OSInAppMessage *)message;
215221
@end
216222

217223
// Pass in nil means a notification will not display

0 commit comments

Comments
 (0)