Skip to content

Commit 5fdbf9b

Browse files
authored
Merge pull request #1250 from OneSignal/fix/failed_firebase_influence_open_unit_test
Fix failing unit test for Firebase influence open
2 parents 178da93 + f479811 commit 5fdbf9b

File tree

1 file changed

+3
-12
lines changed

1 file changed

+3
-12
lines changed

iOS_SDK/OneSignalSDK/UnitTests/UnitTests.m

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -921,16 +921,7 @@ - (void)testFirebaseAnalyticsInfluenceNotificationOpen {
921921
withMutableNotificationContent:nil];
922922
#pragma clang diagnostic pop
923923

924-
// Make sure we are tracking the notification received event to firebase.
925-
XCTAssertEqual(OneSignalTrackFirebaseAnalyticsOverrider.loggedEvents.count, 1);
926-
id received_event = @{
927-
@"os_notification_received": @{
928-
@"campaign": @"Template Name - 1117f966-d8cc-11e4-bed1-df8f05be55bb",
929-
@"medium": @"notification",
930-
@"notification_id": @"b2f7f966-d8cc-11e4-bed1-df8f05be55ba",
931-
@"source": @"OneSignal"}
932-
};
933-
XCTAssertEqualObjects(OneSignalTrackFirebaseAnalyticsOverrider.loggedEvents[0], received_event);
924+
// Note: we are no longer logging the notification received event to Firebase for iOS.
934925

935926
// Trigger a new app session
936927
[UnitTestCommonMethods backgroundApp];
@@ -942,15 +933,15 @@ - (void)testFirebaseAnalyticsInfluenceNotificationOpen {
942933
// TODO: Test carry over causes this influence_open not to fire
943934
// Since we opened the app under 2 mintues after receiving a notification
944935
// an influence_open should be sent to firebase.
945-
XCTAssertEqual(OneSignalTrackFirebaseAnalyticsOverrider.loggedEvents.count, 2);
936+
XCTAssertEqual(OneSignalTrackFirebaseAnalyticsOverrider.loggedEvents.count, 1);
946937
id influence_open_event = @{
947938
@"os_notification_influence_open": @{
948939
@"campaign": @"Template Name - 1117f966-d8cc-11e4-bed1-df8f05be55bb",
949940
@"medium": @"notification",
950941
@"notification_id": @"b2f7f966-d8cc-11e4-bed1-df8f05be55ba",
951942
@"source": @"OneSignal"}
952943
};
953-
XCTAssertEqualObjects(OneSignalTrackFirebaseAnalyticsOverrider.loggedEvents[1], influence_open_event);
944+
XCTAssertEqualObjects(OneSignalTrackFirebaseAnalyticsOverrider.loggedEvents[0], influence_open_event);
954945
}
955946

956947
- (void)testOSNotificationPayloadParsesTemplateFields {

0 commit comments

Comments
 (0)