Skip to content

Commit 664c1cd

Browse files
committed
rename setVisualLevel to setAlertLevel
* Swift automatically renamed setAlertLevel to just `setAlert` so must refine name for swift.
1 parent 2180aa4 commit 664c1cd

File tree

5 files changed

+14
-8
lines changed

5 files changed

+14
-8
lines changed

iOS_SDK/OneSignalDevApp/OneSignalDevApp/AppDelegate.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(
5151

5252
NSLog(@"Bundle URL: %@", [[NSBundle mainBundle] bundleURL]);
5353
[OneSignal.Debug setLogLevel:ONE_S_LL_VERBOSE];
54-
[OneSignal.Debug setVisualLevel:ONE_S_LL_NONE];
54+
[OneSignal.Debug setAlertLevel:ONE_S_LL_NONE];
5555

5656
[OneSignal initialize:[AppDelegate getOneSignalAppId] withLaunchOptions:launchOptions];
5757

iOS_SDK/OneSignalDevApp/OneSignalDevAppClip/AppDelegate.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(
5252
NSLog(@"Bundle URL: %@", [[NSBundle mainBundle] bundleURL]);
5353

5454
[OneSignal.Debug setLogLevel:ONE_S_LL_VERBOSE];
55-
[OneSignal.Debug setVisualLevel:ONE_S_LL_NONE];
55+
[OneSignal.Debug setAlertLevel:ONE_S_LL_NONE];
5656
_notificationDelegate = [OneSignalNotificationCenterDelegate new];
5757

5858
id openNotificationHandler = ^(OSNotificationOpenedResult *result) {

iOS_SDK/OneSignalSDK/OneSignalCore/Source/OneSignalLog.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,12 +38,12 @@ typedef NS_ENUM(NSUInteger, ONE_S_LOG_LEVEL) {
3838

3939
@protocol OSDebug <NSObject>
4040
+ (void)setLogLevel:(ONE_S_LOG_LEVEL)logLevel;
41-
+ (void)setVisualLevel:(ONE_S_LOG_LEVEL)visualLogLevel;
41+
+ (void)setAlertLevel:(ONE_S_LOG_LEVEL)logLevel NS_REFINED_FOR_SWIFT;
4242
@end
4343

4444
@interface OneSignalLog : NSObject<OSDebug>
4545
+ (Class<OSDebug>)Debug;
4646
+ (void)setLogLevel:(ONE_S_LOG_LEVEL)logLevel;
47-
+ (void)setVisualLevel:(ONE_S_LOG_LEVEL)visualLogLevel;
47+
+ (void)setAlertLevel:(ONE_S_LOG_LEVEL)logLevel;
4848
+ (void)onesignalLog:(ONE_S_LOG_LEVEL)logLevel message:(NSString* _Nonnull)message;
4949
@end

iOS_SDK/OneSignalSDK/OneSignalCore/Source/OneSignalLog.m

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
@implementation OneSignalLog
3333

3434
static ONE_S_LOG_LEVEL _nsLogLevel = ONE_S_LL_WARN;
35-
static ONE_S_LOG_LEVEL _visualLogLevel = ONE_S_LL_NONE;
35+
static ONE_S_LOG_LEVEL _alertLogLevel = ONE_S_LL_NONE;
3636

3737
+ (Class<OSDebug>)Debug {
3838
return self;
@@ -42,8 +42,8 @@ + (void)setLogLevel:(ONE_S_LOG_LEVEL)nsLogLevel {
4242
_nsLogLevel = nsLogLevel;
4343
}
4444

45-
+ (void)setVisualLevel:(ONE_S_LOG_LEVEL)visualLogLevel {
46-
_visualLogLevel = visualLogLevel;
45+
+ (void)setAlertLevel:(ONE_S_LOG_LEVEL)logLevel {
46+
_alertLogLevel = logLevel;
4747
}
4848

4949
+ (void)onesignalLog:(ONE_S_LOG_LEVEL)logLevel message:(NSString* _Nonnull)message {
@@ -79,7 +79,7 @@ void onesignal_Log(ONE_S_LOG_LEVEL logLevel, NSString* message) {
7979
if (logLevel <= _nsLogLevel)
8080
NSLog(@"%@", [levelString stringByAppendingString:message]);
8181

82-
if (logLevel <= _visualLogLevel) {
82+
if (logLevel <= _alertLogLevel) {
8383
[[OSDialogInstanceManager sharedInstance] presentDialogWithTitle:levelString withMessage:message withActions:nil cancelTitle:NSLocalizedString(@"Close", @"Close button") withActionCompletion:nil];
8484
}
8585
}

iOS_SDK/OneSignalSDK/Source/OneSignalSwiftInterface.swift

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,12 @@ public extension OneSignal {
7575
}
7676
}
7777

78+
public extension OSDebug {
79+
static func setAlertLevel(_ logLevel: ONE_S_LOG_LEVEL) {
80+
__setAlert(logLevel)
81+
}
82+
}
83+
7884
public extension OSInAppMessages {
7985
static var Paused: Bool {
8086
get {

0 commit comments

Comments
 (0)