Skip to content

Commit 8c9593e

Browse files
committed
fixing outcomes integration tests by resetting the shared session manager
1 parent 8909cc2 commit 8c9593e

File tree

5 files changed

+9
-6
lines changed

5 files changed

+9
-6
lines changed

iOS_SDK/OneSignalSDK/OneSignalOutcomes/Source/OutcomeEvents/OSSessionManager.h

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,9 @@
3636

3737
@interface OSSessionManager : NSObject
3838

39-
+ (OSSessionManager*)sharedSessionManager;
39+
+ (OSSessionManager *)sharedSessionManager;
40+
41+
+ (void)resetSharedSessionManager;
4042

4143
@property (nonatomic) id<SessionStatusDelegate> _Nullable delegate;
4244

iOS_SDK/OneSignalSDK/OneSignalOutcomes/Source/OutcomeEvents/OSSessionManager.m

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,10 @@ + (OSSessionManager*)sharedSessionManager {
4545
return _sessionManager;
4646
}
4747

48+
+ (void)resetSharedSessionManager {
49+
_sessionManager = nil;
50+
}
51+
4852
- (instancetype _Nonnull)init:(Class<SessionStatusDelegate>)delegate withTrackerFactory:(OSTrackerFactory *)trackerFactory {
4953
if (self = [super init]) {
5054
_delegate = delegate;

iOS_SDK/OneSignalSDK/Source/OneSignal.m

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -569,6 +569,8 @@ + (void)clearStatics {
569569
_registerUserSuccessful = false;
570570

571571
_delayedSMSParameters = nil;
572+
573+
[OSSessionManager resetSharedSessionManager];
572574
}
573575

574576
// Set to false as soon as it's read.

iOS_SDK/OneSignalSDK/UnitTests/OutcomeIntegrationTests.m

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ of this software and associated documentation files (the "Software"), to deal
4646
#import "NSTimerOverrider.h"
4747

4848
@interface OneSignal ()
49-
+ (OSSessionManager*)sessionManager;
5049
+ (OSTrackerFactory*)trackerFactory;
5150
+ (OneSignalOutcomeEventsController*)outcomeEventsController;
5251
@end
@@ -141,7 +140,6 @@ - (void)testDirectSession_onFocusAttributed {
141140
[NSDateOverrider advanceSystemTimeBy:5];
142141

143142
// 2. Background app, receive notification, and open notification
144-
[OneSignalTracker onFocus:true];
145143
[UnitTestCommonMethods backgroundApp];
146144
[UnitTestCommonMethods receiveNotification:@"test_notification_1" wasOpened:YES];
147145

iOS_SDK/OneSignalSDK/UnitTests/OutcomeIntegrationV2Tests.m

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,6 @@
4747
#import "NSTimerOverrider.h"
4848

4949
@interface OneSignal ()
50-
+ (OSOutcomeEventsCache*)outcomeEventsCache;
51-
+ (OSSessionManager*)sessionManager;
52-
+ (OSTrackerFactory*)trackerFactory;
5350
+ (OneSignalOutcomeEventsController*)outcomeEventsController;
5451
@end
5552

0 commit comments

Comments
 (0)