Skip to content

Commit eb16f40

Browse files
committed
Don't handle addAlias conflict
* When we set tags and it goes over limit, we don't delete them locally. * Let's do the same for added aliases that can't be added to the user due to conflict * The SDK will refresh itself on new sessions * We will need better systematic way to address these types of failure cases
1 parent 2202fe7 commit eb16f40

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

iOS_SDK/OneSignalSDK/OneSignalUser/Source/OSIdentityOperationExecutor.swift

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -206,15 +206,6 @@ class OSIdentityOperationExecutor: OSOperationExecutor {
206206
// The subscription has been deleted along with the user, so remove the subscription_id but keep the same push subscription model
207207
OneSignalUserManagerImpl.sharedInstance.pushSubscriptionModel?.subscriptionId = nil
208208
OneSignalUserManagerImpl.sharedInstance._logout()
209-
} else if responseType == .conflict {
210-
self.addRequestQueue.removeAll(where: { $0 == request})
211-
OneSignalUserDefaults.initShared().saveCodeableData(forKey: OS_IDENTITY_EXECUTOR_ADD_REQUEST_QUEUE_KEY, withValue: self.addRequestQueue)
212-
guard OneSignalUserManagerImpl.sharedInstance.isCurrentUser(request.identityModel)
213-
else {
214-
return
215-
}
216-
// Alias(es) already exists on another user, remove from identity model
217-
OneSignalUserManagerImpl.sharedInstance.user.identityModel.removeAliases(Array(request.aliases.keys))
218209
} else if responseType != .retryable {
219210
// Fail, no retry, remove from cache and queue
220211
self.addRequestQueue.removeAll(where: { $0 == request})

0 commit comments

Comments
 (0)