-
Notifications
You must be signed in to change notification settings - Fork 266
Feat: live activities receive receipts #1592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix calculation of one day in seconds. This bug had no side effects except keeping old irrelevant data too long.
* Let's arbitrarily keep receive requests up to 30 days. If these requests can't be sent for 30 days, let's drop them. Typically, they will be removed from cache when the request is successful, or fail with un-retryable error.
* Listen for `contentUpdates` as a way to know the live activity has been updated via a notification or "in app". This asynchronous sequence is triggered for all PTS, PTU, and live activities that are started and updated "in app". * We will check for notification ID to know if this change was generated from a notification and track the receive receipt.
The `testRemoveUpdateTokenWithSuccessfulRequest` should use `OSRequestRemoveUpdateToken` instead of `OSRequestRemoveStartToken`, fix small bug.
* Add a basic tests for the request * Add this type to the the uncaching test
3f044ac to
2a2d695
Compare
jkasten2
approved these changes
Oct 17, 2025
This was referenced Oct 27, 2025
Merged
This was referenced Nov 7, 2025
This was referenced Dec 4, 2025
This was referenced Dec 4, 2025
This was referenced Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Add receive receipts for live activities notifications, which covers push-to-start and push-to-update notifications.
Details
Relies on the contentUpdates asynchronous sequence to know that a live activity may be update remotely. This appears to be consistently triggered when new live activities are started, and when updates are made to existing live activities.
Motivation
Add analytics for Live Activities
Scope
OneSignalLiveActivityAttributesreport_receivedendpoint with additional properties for the live activityTesting
Unit testing
Manual testing
iPhone 13 on iOS 18.6.2
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is