Skip to content

Conversation

@nan-li
Copy link
Contributor

@nan-li nan-li commented Nov 20, 2025

Description

One Line Summary

Use Xcode's built in code coverage reporting, and add all 10 SDK frameworks for analysis.

Details

  • Add all frameworks to check code coverage for (there are 10).
  • Reminder there are 2 test plans that can be run, and coverage needs to be specified for each one:
    • UnitTestApp_TestPlan_Reduced (default plan in CI)
    • UnitTestApp_TestPlan_Full (default plan in Xcode)

Motivation

Increase testing and monitor code coverage for tests.

Scope

Testing only for code coverage

Testing

Unit testing

No new tests added
Badge test is flaky, causing tests fail.

Manual testing

Ran UnitTestApp_TestPlan_Reduced test plan and UnitTestApp_TestPlan_Full test plan with coverage.

UnitTestApp_TestPlan_Reduced
UnitTestApp_TestPlan_Reduced

UnitTestApp_TestPlan_Full
UnitTestApp_TestPlan_Full

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes
  • Tests

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

This change is Reviewable

@nan-li nan-li changed the title chore: add code coverage for all targets chore(tests): add code coverage for all targets Nov 20, 2025
* Add all frameworks to check code coverage for.
* Reminder there are 2 test plans that can be run:
- UnitTestApp_TestPlan_Reduced (default plan in CI)
- UnitTestApp_TestPlan_Full (default plan in Xcode)
@nan-li nan-li force-pushed the ci/add_code_coverage branch from a69c00c to f828623 Compare November 20, 2025 20:50
@nan-li nan-li requested a review from a team November 20, 2025 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants