Skip to content

Conversation

@nan-li
Copy link
Contributor

@nan-li nan-li commented Nov 26, 2025

Description

One Line Summary

Update flaky badge clearing tests that have been consistently failing in CI.

Details

These two badge clearing tests have been consistently flaky, as the usage of UIApplication.shared.applicationIconBadgeNumber appears to be async so values are not accurate immediately. Additionally, this API and deprecated, and we have removed this usage from the SDK itself in #1568. These changes will also update the tests to match current behavior.

Motivation

Fix CI

Scope

Tests only

Testing

Unit testing

Updated 2 badge clearing tests

Manual testing

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes
  • Tests

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

This change is Reviewable

@nan-li nan-li changed the base branch from main to tests/add_iam_tests November 26, 2025 01:04
@nan-li nan-li force-pushed the chore/fix_flaky_badge_tests branch 2 times, most recently from 5b5ce67 to c286ea0 Compare November 26, 2025 01:49
@nan-li nan-li changed the title Chore/fix flaky badge tests chore(tests): Update flaky badge clearing tests Nov 26, 2025
@nan-li nan-li requested a review from a team November 26, 2025 01:52
@nan-li nan-li force-pushed the tests/add_iam_tests branch 2 times, most recently from 19374af to 2267465 Compare December 1, 2025 22:10
Base automatically changed from tests/add_iam_tests to main December 5, 2025 16:30
These two tests have been consistently flaky, the usage of `UIApplication.shared.applicationIconBadgeNumber` is async and deprecated, and we have removed this usage from the SDK itself. Now update the tests to match current behavior.
@nan-li nan-li force-pushed the chore/fix_flaky_badge_tests branch from c286ea0 to 3686769 Compare January 6, 2026 08:39
@nan-li nan-li merged commit 8b7218d into main Jan 7, 2026
3 checks passed
@nan-li nan-li deleted the chore/fix_flaky_badge_tests branch January 7, 2026 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants