Skip to content

Conversation

@fadi-george
Copy link
Collaborator

@fadi-george fadi-george commented Dec 5, 2025

Description

One Line Summary

  • call shared sdk action to create release prs in wrapper sdks for new ios sdk version

Details

  • updates publish workflow action to call shared sdk action

Note: I ran this action after testing the android action so theres additional commits.
See example runs:
Action: https://github.com/OneSignal/OneSignal-iOS-SDK/actions/runs/19948041415
RN: OneSignal/react-native-onesignal#1870
Flutter: OneSignal/OneSignal-Flutter-SDK#1094
Cordova: OneSignal/OneSignal-Cordova-SDK#1135
Unity: OneSignal/OneSignal-Unity-SDK#833

Motivation

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

@fadi-george fadi-george changed the title ci: ci: create release prs for wrappers for new ios sdk release Dec 5, 2025
@fadi-george fadi-george merged commit 6a4ce90 into main Dec 5, 2025
2 checks passed
@fadi-george fadi-george deleted the fg/wrapper-prs branch December 5, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants