Skip to content

Conversation

@nan-li
Copy link
Contributor

@nan-li nan-li commented Jan 9, 2026

Description

One Line Summary

Fix failing create-release-prs action by updating runner image and fixing a change in workflow file.

Details

Motivation

Make the release automation work

Scope

release automation

  1. The macOS-13 based runner images are now retired. For more details, see [macOS] The macOS 13 Ventura based runner images will begin deprecation on September 22nd and will be fully unsupported by December 4th for GitHub and ADO actions/runner-images#13046.
  2. ci: create release prs for wrappers for new ios sdk release #1618 had changes for create-release-prs but we can't set the --local user outside the OneSignal-XCFramework git repository. --local can only be used inside a git repository and we are modifying another one. It needs to move back into the body of the OneSignal-XCFramework repository steps.

Testing

Manual testing

Release workflow succeeds: https://github.com/OneSignal/OneSignal-iOS-SDK/actions/runs/20843688011

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

nan-li added 2 commits January 8, 2026 15:01
The macOS-13 based runner images are now retired. For more details, see actions/runner-images#13046.
Errors:
- Run OneSignal/sdk-actions/.github/actions/setup-git-user@main
- Run git config --local user.email "[email protected]"
- fatal: --local can only be used inside a git repository
It needs to be moved back into the body of the xcframework repository steps
@nan-li nan-li requested a review from a team January 9, 2026 07:16
@nan-li nan-li merged commit 37949ad into main Jan 9, 2026
6 checks passed
@nan-li nan-li deleted the chore/actions_macos_version branch January 9, 2026 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants