Skip to content

chore: migrate build tooling from Bun to Vite+#291

Merged
fadi-george merged 8 commits intomainfrom
fadi/sdk-4199-add-vite-to-expo-sdk
Mar 21, 2026
Merged

chore: migrate build tooling from Bun to Vite+#291
fadi-george merged 8 commits intomainfrom
fadi/sdk-4199-add-vite-to-expo-sdk

Conversation

@fadi-george
Copy link
Contributor

Description

One Line Summary

Migrate the project's build tooling, package management, and test infrastructure from Bun to Vite+.

Details

Motivation

Standardize on Vite+ as the unified toolchain for this project, replacing Bun for package management, building, and testing. Vite+ wraps Vite, Rolldown, Vitest, tsdown, Oxlint, and Oxfmt into a single vp CLI, simplifying the development workflow and aligning with the broader SDK toolchain direction.

Scope

  • Removed Bun lockfile (bun.lock, bunfig.toml) and switched to pnpm via Vite+ (pnpm-lock.yaml)
  • Removed unused config files (.oxlintrc.json, .prettierrc, .prettierignore, tsconfig.json) now handled by Vite+
  • Removed unused GitHub workflow (Zapier.yml) and probot metadata
  • Added vite.config.ts for build and test configuration
  • Added VS Code settings and extensions for Vite+ integration
  • Added AGENTS.md with Vite+ workflow documentation
  • Added .vite-hooks/pre-commit hook
  • Migrated test imports from vitest to vite-plus/test
  • Migrated example apps to use Vite+ tooling
  • Replaced default Expo entry with custom index.js in demo example

What is NOT changing

  • No changes to the core plugin logic (withOneSignalIos, withOneSignalAndroid, etc.)
  • No changes to the NSE (Notification Service Extension) templates — files were only moved/renamed
  • No functional changes to any tests — only import paths updated

Testing

Manual testing

  • Ran vp install successfully
  • Ran vp check (format, lint, type checks) — all passing
  • Ran vp test — all tests passing
  • Verified vp build produces correct output

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have personally tested this on my device, or explained why that is not possible
    • Build tooling migration only — no runtime changes to the plugin
  • I have tested this on the latest version of the plugin
  • I have tested this on both Android and iOS, or explained why that is not possible
    • No platform-specific runtime changes — this is a build tooling migration

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

Made with Cursor

@fadi-george fadi-george force-pushed the fadi/sdk-4199-add-vite-to-expo-sdk branch from ec60899 to a5eceb1 Compare March 20, 2026 23:03
@fadi-george fadi-george merged commit 09f43e8 into main Mar 21, 2026
3 of 4 checks passed
@fadi-george fadi-george deleted the fadi/sdk-4199-add-vite-to-expo-sdk branch March 21, 2026 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants