Fix: Android use OneSignalLog, don't use android.util.Log, also fixes crash
#1806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nan-li
changed the title
android.util.Log, fix log crashandroid.util.Log, also fixes crash
nan-li
force-pushed
the
fix/android_logging
branch
2 times, most recently
from
ee6df90 to
d6dda9c
Compare
* Obey log level set by developers and don't use android.util.Log to log information. * Also some usages of android.util.Log were incorrect (by not setting TAG) and would get a NPE
nan-li
force-pushed
the
fix/android_logging
branch
from
d6dda9c to
d31163a
Compare
jinliu9508
approved these changes
May 8, 2025
jkasten2
approved these changes
May 8, 2025
| private void removeHandlers() { | ||
| if(!oneSignalInitDone) { | ||
| Log.i("OneSignal", "OneSignal React-Native SDK not initialized yet. Could not remove handlers."); | ||
| Logging.debug("OneSignal React-Native SDK not initialized yet. Could not remove handlers.", null); |
Member
There was a problem hiding this comment.
nit, no need to pass in null as the 2nd parameter to our OneSignal Logging functions, it as optional parameter.
Contributor
Author
There was a problem hiding this comment.
Since we are calling this Kotlin-defined method from Java, we have to pass the 2nd parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Obey log level set by developers and also fixes NPE crash when some malformed logs were actually invoked.
Details
Motivation
Scope
Logging only
The bug was some usages of
android.util.Loghad arguments conflated with our OneSignalLogging. OneSignalLog's 2nd parameter is a nullable throwable, but android.util.Log's 1st argument is a string TAG to represent your collection, and the 2nd parameter is the actual print statement.Testing
Unit testing
Manual testing
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is