Skip to content

Conversation

@fadi-george
Copy link
Collaborator

@fadi-george fadi-george commented Sep 23, 2025

Description

One Line Summary

  • adds custom events support for the react native package
Screenshot 2025-09-23 at 11 55 26 AM Screenshot 2025-09-23 at 4 40 26 PM

Details

  • sets versions of android and ios to versions that have custom events logic
  • expose android trackEvent method via RNOneSignal.java
  • expose ios trackEvent method via RCTOneSignalEventEmitter.m
  • deleted original RN example project and set it up with latest versions
  • add new trackEvent react-native method via src/index.ts
  • removed material ui package for react native example
  • adds trackEvent demo action for the example project

Motivation

Code change is to allow developers to use custom-events with the react-native package.

Testing

Manual testing

Run ios and android emulators and tested the trackEvent action. See screenshot of the custom event actually being recorded.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

@nan-li
Copy link
Contributor

nan-li commented Sep 24, 2025

Can you give more details about the example app changes, like versions, etc?
Is it related to new react native architecture?

@fadi-george
Copy link
Collaborator Author

fadi-george commented Sep 24, 2025

Can you give more details about the example app changes, like versions, etc? Is it related to new react native architecture?

Had to remake example since i kept get errors either glog, another package, just constant build errors.
its just a remade w/ "react-native": "0.81.4" and then I copied over the old views (OSButtons , etc.).

@fadi-george
Copy link
Collaborator Author

Ill split up the example project changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants