Skip to content

Conversation

@fadi-george
Copy link
Collaborator

@fadi-george fadi-george commented Oct 28, 2025

Description

One Line Summary

Details

  • removes eslint config files and replaces them with oxlint tool
  • removes useless jest tests for examples folder (tests will be redone for main src files)
  • replaces yarn with the bunjs runtime and adds bunlock file

Motivation

  • want to have fast/performant linting

Manual testing

Ran both emulators from example folder.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

@fadi-george fadi-george force-pushed the fg/oxc-lint branch 2 times, most recently from 5cca098 to eb27512 Compare October 28, 2025 21:56
Copy link
Contributor

@sherwinski sherwinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Why is this change needed? The motivations section mentions performant linting; is the current linter prohibitively slow? I'd like to know what the value-add is for updating our tooling this way.

  2. Several commits (e.g. 21d6f36 and 5c83c98) mix config, CI, and formatting updates. I would split these out or else the diffs become tedious to review.

@fadi-george
Copy link
Collaborator Author

  1. Why is this change needed? The motivations section mentions performant linting; is the current linter prohibitively slow? I'd like to know what the value-add is for updating our tooling this way.
  2. Several commits (e.g. 21d6f36 and 5c83c98) mix config, CI, and formatting updates. I would split these out or else the diffs become tedious to review.
  1. Our eslint config is a major version behind and oxlint is the newer standard linter next to biome. Our lint command isnt necessary slow but while we are making improvements to our ci/cd system, we may as well polish existing flows up.
  2. Split up the bun installation pr. I ran the formatter which did clean up some files but these number of changed files is still small.

@fadi-george fadi-george merged commit efe609b into main Oct 29, 2025
4 checks passed
@fadi-george fadi-george deleted the fg/oxc-lint branch October 29, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants