Skip to content

Conversation

@sherwinski
Copy link
Contributor

@sherwinski sherwinski commented Oct 30, 2025

Description

One Line Summary

The OSDemo component was registering 10 event listeners but never removing them during clean up. This change updates the example to provide an instance of best practices for anyone using it as a reference.

Details

Motivation

I noticed this while testing some other event listener behavior in the library.

Scope

Scope is limited to the example app we provide in the repo.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

The OSDemo component was registering 10 event listeners but never removing them during clean up. This change updates the example to provide an instance of best practices for anyone using it as a reference.
@sherwinski sherwinski force-pushed the example/chore/remove-event-listeners branch from 1619dff to d4b1efa Compare October 30, 2025 21:58
@fadi-george
Copy link
Collaborator

Run lint fix

@sherwinski sherwinski merged commit 7dabf84 into main Oct 30, 2025
4 checks passed
@sherwinski sherwinski deleted the example/chore/remove-event-listeners branch October 30, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants