Add hack for adding new control codes to messages #1849
Conversation
|
Any opinion on merging this prior to silver rupee shuffle? Or should I just merge it into the silver rupee branch and it'll all be under that PR? |
|
Merging before silver rupee shuffle would be useful for #1841. |
|
Given that there are already 3 separate use-cases for this PR (current collected small key/silver rupee count, using cosmetics to customize gendered terms referring to Link, and #1854), I'm in favor of merging it. |
|
I'm good w/ the idea of merging this beforehand. I want to revisit the MessageContext struct a bit before marking this ready. The struct, which was taken from decomp, does not match the struct used by 1.0. Would like to get it corrected before merging. Edit: I'm just an idiot the struct matches perfectly :) |
rrealmuto
force-pushed
the
control_codes
branch
from
dbfea01 to
fd04974
Compare
rrealmuto
force-pushed
the
control_codes
branch
from
2cec64c to
c88d87c
Compare
|
Closing this because #1841 was already merged without it. It will be included with silver rupee shuffle. |
3 participants
Wanted to get folks thoughts on this...
This PR adds a framework for adding additional text control codes to the game. No addition codes are implemented in this PR, but this PR is an enabler for PR #1814 so that the silver rupee count may be displayed in the text box when acquiring one, without requiring duplicating messages. Can also add things like key counts or any other dynamically generated messages.
To add new control codes, add the logic for the code to message.c, and add the control code to CONTROL_CODES in Messages.py
Also adds a new function to the item table for resolving an alternate text ID. This can be used to change the text ID based on some condition, such as collecting all of the silver rupees for a particular room.
Example showing a new control code being used for silver rupee shuffle: