Use separate text component for multiworld item recipient #2035
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the hack overriding the vanilla player name text component with the recipient of an item in multiworld, and instead uses the feature originally proposed as #1849 and ultimately merged as part of #1814 to add a custom text component for this purpose.
Unlike the previous hack, this new text component is not initialized properly at all times, so it must only be used in the text box for an overridden item location. The text boxes used for songs and bottles had to be duplicated to address this, with the original ones only being used for songs on songs and bottle refills via the vanilla code, and the new ones being used for songs as items and bottle items via the override system. A similar change still needs to be made to shops, see the issue linked below.
Fixes #208. Fixes #848. Fixes #1854.
Issues keeping this in draft state