Skip to content

Conversation

@fenhl
Copy link
Collaborator

@fenhl fenhl commented Jul 9, 2023

This removes the hack overriding the vanilla player name text component with the recipient of an item in multiworld, and instead uses the feature originally proposed as #1849 and ultimately merged as part of #1814 to add a custom text component for this purpose.

Unlike the previous hack, this new text component is not initialized properly at all times, so it must only be used in the text box for an overridden item location. The text boxes used for songs and bottles had to be duplicated to address this, with the original ones only being used for songs on songs and bottle refills via the vanilla code, and the new ones being used for songs as items and bottle items via the override system. A similar change still needs to be made to shops, see the issue linked below.

Fixes #208. Fixes #848. Fixes #1854.

Issues keeping this in draft state

@fenhl fenhl added Type: Bug Something isn't working Component: ASM/C Changes some internals of the ASM/C libraries labels Jul 9, 2023
@fenhl fenhl force-pushed the mw-name-text-component branch 2 times, most recently from 82d0ec8 to 27b6fa7 Compare August 11, 2023 21:18
@fenhl fenhl force-pushed the mw-name-text-component branch from 27b6fa7 to d5f6f61 Compare August 26, 2023 13:31
@fenhl fenhl marked this pull request as ready for review August 26, 2023 13:37
@cjohnson57
Copy link
Collaborator

Shouldn't this increment the coop context?

@fenhl
Copy link
Collaborator Author

fenhl commented Aug 26, 2023

No, this change is transparent to multiworld plugins.

@cjohnson57 cjohnson57 merged commit d09f6d5 into OoTRandomizer:Dev Aug 26, 2023
@fenhl fenhl deleted the mw-name-text-component branch August 26, 2023 23:45
@fenhl fenhl mentioned this pull request Aug 31, 2023
@fenhl fenhl added this to the 8.0 milestone Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: ASM/C Changes some internals of the ASM/C libraries Type: Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Winner heart piece always uses own player name Tektite Grotto PoH in Multiworld? Name not appearing in textbox.

2 participants