Added option to force Rauru's reward to be a dungeon reward even when dungeon rewards are shuffled

[Echopixel]

These changes implement #2225 and adds a dropdown to add a third option to how you want to handle Rauru's reward in your seed.

Might be logic I'm missing since I'm still understanding how everything is working but initial testing seemed good under various different shuffle and Rauru settings. Also the comment in #1833 that triggered the parent issue suggested changing the default of this setting to be off so I did but set all the presets to just "free" to keep them how they would be before this change. If that default isn't actually wanted just let me know!

[cjohnson57]

Looks good to me, appreciate the PR and changes!

[fenhl]

A couple notes from testing:

1. The ToT Reward from Rauru location is missing from the locations object in the spoiler log with the new option.
2. How do we want this to behave regarding which reward is placed on Rauru in regional reward shuffle? One might expect it to always be the Light medallion, whereas the current implementation seems to place a random reward there.

[Echopixel]

A couple notes from testing:

1. The `ToT Reward from Rauru` location is missing from the `locations` object in the spoiler log with the new option.

2. How do we want this to behave regarding which reward is placed on Rauru in regional reward shuffle? One might expect it to always be the Light medallion, whereas the current implementation seems to place a random reward there.

1. Nice catch and a good chance for me to figure out how the spoiler log works lol, pushed a change that should fix it.

2. I am rather unfamiliar with most of OoTR only really starting to play the last few weeks, so I leave that up to you guys how it should work. Also I think I misunderstood what you meant and changed it to always give Light Medallion at the start when you choose Regional. Are you saying it should give a random medallion at start with Regional as it did before I made the last commit, but the actual check should always give Light Medallion also for Regional (assuming the free one wasn't Light already). I think my assumption was Light, if it wasn't given, would be placed somewhere near Hyrule Castle, but I'm also not familiar with how the regional shuffling works.

[fenhl]

I intentionally phrased it as an open question so you and others could weigh in (though you saying you're not as familiar yet and leaving it up to others is completely valid). I think the free reward should remain implemented as skipping the Rauru location, so there are two ways I could see it working with the new option:

1. Rauru location is always the Light medallion. This would directly follow the restrictions set by both regional reward shuffle and Free Reward from Rauru (forced), but would reduce seed variety.
2. Rauru location is a random reward, and if it's not the Light medallion, the Light medallion is in the Light region (Hyrule Field, Lon Lon Ranch, Market, Temple of Time, Hyrule Castle, Outside Ganon's Castle, Inside Ganon's Castle). This matches how rewards shuffled to any dungeon has to work when combined with the new option, since otherwise there would be no item to place on Rauru.

[Echopixel]

I personally like option 2, for the reason you stated about option 1 reducing seed variety. I believe this was how I originally had it due to the assumption of how I thought it needed to work, but I think I'm understanding Regional more. So if it's Regional shuffle it's not typical for a reward to leave it's region, but by doing this, that would be the case but only in this circumstance. I could also add a 4th option to fit both scenarios if people like both options?

Something like if Regional shuffle is on, forced = Light, forced_regionless = random? Or if forced is chosen, enable a Checkbutton for whether it ignores Region or not?

[cjohnson57]

Option 1 makes more sense to me. Option 2 feels overly complex. But I don't have a strong opinion on it.

[fenhl]

A 4th option for the setting would be too much GUI bloat for such a minor thing imo (the option added in this PR is already pretty minor). I think I agree with @cjohnson57 here, and seed variety should be a low priority compared to other concerns like making combinations of settings work as expected when possible.

[Echopixel]

That makes sense, then I'll leave the change I last made which does that and excludes randomizing the Rauru reward when it's Regional shuffling.