Skip to content

Conversation

@GSKirox
Copy link
Collaborator

@GSKirox GSKirox commented Jan 5, 2026

This is a port of a 1.1/1.2 exclusive fix for Scarecrow song, which can be found here : https://github.com/zeldaret/oot/blob/eb5dac74d6435baf85ced9158d3ff915ba8872ca/src/audio/game/general.c#L1718-L1723
If the last note played on Ocarina had a vibrato (X direction on the stick while playing) before the player records scarecrow song as child, then the vibrato status was not reset, and kept in the first note of the song. Which makes trying to play the same song as adult scarecrow 100% fail.
Credits to flagrama for the steps to reproduce :

Before setting scarecrow song, start the ocarina, play one note with vibrato (control stick left or right) and while that note is being played, press B to exit ocarina.
This vibrato state is now saved as the previous state for the ocarina notes. Scarecrow song recording skips changing that value at all in 1.0 so now when you start the recording vibrato is the old value while you record.
Going adult and playing the song back to the scarecrow should now fail.

Testing

Did the above steps to reproduce and scarecrow song was recorded properly this time.
Here is a patch file with the fix + using the plando of #2486 for convenience.
OoT_Scarecrow_vibrato_11_fix.zip

@GSKirox GSKirox added Type: Bug Something isn't working Component: ASM/C Changes some internals of the ASM/C libraries Status: Needs Review Someone should be looking at it labels Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: ASM/C Changes some internals of the ASM/C libraries Status: Needs Review Someone should be looking at it Type: Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant