Adjust file select version line shortening#2529
Open
fenhl wants to merge 1 commit intoOoTRandomizer:Devfrom
Open
Adjust file select version line shortening#2529fenhl wants to merge 1 commit intoOoTRandomizer:Devfrom
fenhl wants to merge 1 commit intoOoTRandomizer:Devfrom
Conversation
fenhl
added
Status: Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the next major release adding an extra digit, the version info on the file select screen will exceed the 21-character limit. Before this PR, this would result in the version info being shortened to
ver. 10.0.0 Release. With this PR, it's shortened toversion 10.0 Releaseinstead, omitting the patch number, which is also consistent with how we refer to releases on ootrandomizer.com and in announcements.Additionally, for both releases and Dev versions, this adds version display variants that are shortened even further in case the shortened version still doesn't fit:
version→ver.→v.→v(the last one with no space). These are very unlikely to matter for main any time soon, but are useful for forks, which tend to have longer version info due to including the branch name and supplementary versions and such.Testing
Tested with an unmodified
__version__string (9.0.2 f.LUM) as well as10.0.0 Releaseand255.255.255 Fenhl-255: