Don't assume x86_64 when looking for espeak-ng-data.#557
Open
dsalt wants to merge 1 commit intoOoliteProject:masterfrom
Open
Don't assume x86_64 when looking for espeak-ng-data.#557dsalt wants to merge 1 commit intoOoliteProject:masterfrom
dsalt wants to merge 1 commit intoOoliteProject:masterfrom
Conversation
On Debian-like systems, the data is stored in an architecture-dependent location, so on aarch64 the usual location is /usr/share/aarch64-linux-gnu. (Almost certainly safe to assume *-linux-gnu, so this patch still does that.)
Contributor
|
I imagine that this will be fine. I didn't see any results from the build-all GH Actions build on your fork to check if a built appimage worked. |
mcarans
reviewed
Mar 11, 2026
| SEARCH_PATHS=( | ||
| "/usr/local/share/espeak-ng-data" | ||
| "/usr/lib/x86_64-linux-gnu/espeak-ng-data" | ||
| "/usr/lib/$(/usr/bin/arch 2>/dev/null || echo x86_64)-linux-gnu/espeak-ng-data" |
Contributor
There was a problem hiding this comment.
@dsalt I suggest this as uname is universal:
/usr/lib/$(uname -m 2>/dev/null || echo x86_64)-linux-gnu/espeak-ng-data
mcarans
reviewed
Mar 11, 2026
| return 1 | ||
| fi | ||
| # Some distributions put the data in arch-specific paths | ||
| HOSTARCH="$(usr/bin/arch 2>/dev/null || echo x86_64)" |
Contributor
There was a problem hiding this comment.
I suggest using uname -m for this too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Debian-like systems, the data is stored in an architecture-dependent location, so on aarch64 the usual location is /usr/share/aarch64-linux-gnu.
(Almost certainly safe to assume *-linux-gnu, so this patch still does that.)