Add static method to hash object pool from raw data pointer#662
Open
patrykkrz wants to merge 1 commit intoOpen-Agriculture:mainfrom
Open
Add static method to hash object pool from raw data pointer#662patrykkrz wants to merge 1 commit intoOpen-Agriculture:mainfrom
patrykkrz wants to merge 1 commit intoOpen-Agriculture:mainfrom
Conversation
Contributor
|
Hi , nice proposal. In my opinion, this is a case for using a span(https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#i13-do-not-pass-an-array-as-a-single-pointer) type(DataSpan in this lib). I wanted to suggest using it, but as usual, before recommending it, I decided to look into the implementation and unfortunately found a critical bug in it (#663) :)) |
Author
|
I considered std::span, but it requires C++20. |
patrykkrz
force-pushed
the
main
branch
2 times, most recently
from
0940eec to
9e2a09a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Added an alternative method for computing a hash from an ObjectPool. The current version requires passing a vector, which can be problematic on hardware with limited RAM. The pointer-based method, which takes a data pointer and size, can be useful, for example, when storing the ObjectPool in flash memory.