Macro Object IDs #18
Open
Macro Object IDs #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also introduced filter/search bar, and sorting of objects
Added validation to restrict Macro object IDs to the 0-255 range in both object creation and configuration. Introduced a modal error window in the UI for invalid Macro IDs and improved conflict messaging in the object configuration panel. This was not fully achieved...
Changed the rustflags for the wasm32-unknown-unknown target to use '--cfg=wasm_js' for improved compatibility and clarity.
Fixing some merge errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some handling so that macros are forced to IDs of 0-255 which is the standard for any VT version less than 5. Also updated so that all other object types now start an ID of 256 and count up.
If you try to add a macro after you have filled all the IDs from 0-255 you get this popup:
If you try and edit a macro higher than 255 it shows this:
I wanted to have it say "Macro IDs must be 0-255!" but I couldn't figure out how to make it stay... See the code in: src/object_configuring.rs
I have attached the pool that I used to test the edge cases (trying to add more macros that 255 and editing a macro to and ID greater than 255).
object_pool_macro.iop.zip