Merged
Conversation
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
mmichal10
force-pushed
the
fix-detach-cmpl
branch
from
ca9a5ca to
dde2f35
Compare
jfckm
reviewed
Mar 26, 2025
jfckm
left a comment
jfckm
left a comment
There was a problem hiding this comment.
If those are our first detach/attach tests maybe run some basic I/O as a smoke test?
mmichal10
force-pushed
the
fix-detach-cmpl
branch
from
dde2f35 to
43a5fe0
Compare
Contributor
Author
Done |
robertbaldyga
previously approved these changes
Mar 26, 2025
rafalste
reviewed
Mar 26, 2025
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
mmichal10
force-pushed
the
fix-detach-cmpl
branch
from
43a5fe0 to
a5a92b5
Compare
Request could be completed and freed before the statistics were updated Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
mmichal10
force-pushed
the
fix-detach-cmpl
branch
from
a5a92b5 to
e01eef6
Compare
Otherwise the D2C requests can't be returned to the proper memory pool, which effectively leds to a memory leak Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
mmichal10
force-pushed
the
fix-detach-cmpl
branch
from
e01eef6 to
e762a5a
Compare
robertbaldyga
approved these changes
Mar 27, 2025
jfckm
approved these changes
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.