cleaning: Don't reschedule through the queue under metadata lock #896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert Baldyga <robert.baldyga@huawei.com>
robertbaldyga
force-pushed
the
fix-cleaning-set-policy
branch
7 times, most recently
from
a224c73 to
2f3dabb
Compare
mmichal10
previously approved these changes
Oct 8, 2025
robertbaldyga
force-pushed
the
fix-cleaning-set-policy
branch
from
2f3dabb to
770a311
Compare
added 3 commits
October 9, 2025 11:10
Make it possible to parametrize step array. Signed-off-by: Robert Baldyga <robert.baldyga@huawei.com>
Signed-off-by: Robert Baldyga <robert.baldyga@huawei.com>
Signed-off-by: Robert Baldyga <robert.baldyga@huawei.com>
robertbaldyga
force-pushed
the
fix-cleaning-set-policy
branch
from
770a311 to
e8b8a65
Compare
mmichal10
previously approved these changes
Oct 9, 2025
Deixx
reviewed
Oct 9, 2025
added 2 commits
October 9, 2025 12:27
Rescheduling through the queue, while holding metadata lock, leads to deadlock in SPDK, as the management queue poller can be run on the same reactor as in-flight IO request, which may also try to acquire metadata lock. Signed-off-by: Robert Baldyga <robert.baldyga@huawei.com>
Silence "WARNING: Prefer 'unsigned int' to bare use of 'unsigned'". OCF uses that convention for a long time and it would require change in many places to enforce the one suggested by checkpatch.pl. Silence "WARNING: do not add new typedefs". Typedefs are extensively used in OCF. Silence attribute macros warning. It breaks compilation in pyOCF. Signed-off-by: Robert Baldyga <robert.baldyga@huawei.com>
robertbaldyga
force-pushed
the
fix-cleaning-set-policy
branch
from
e8b8a65 to
55a1e93
Compare
Deixx
approved these changes
Oct 9, 2025
rafalste
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.