Allow bulding RPMs with mock #1674
Conversation
Is this something I need to fix? Or is there a maintainer or otherwise automated action that will update this, either before or during landing? |
|
thanks for your contribution. We're currently on a tight schedule so it may take us some time to review your patch. Regarding the licence check - each file in the project has a header with copyrights. The script checks if the license has been updated for each file modified in your pull request. You could refer e.g. to this contribution from the community on how to update the license |
Sure. At your convenience.
Indeed. We did much the same when I worked at Intel also.
Ahh. Thanks. Nice example. I wasn't sure if your policies allowed contributors to add copyright or whether it was required to be signed over to your project/company. I will update per the example. |
brianjmurrell
force-pushed
the
build-rpm-with-mock
branch
from
41b3e1a to
5add67f
Compare
rafalste
force-pushed
the
build-rpm-with-mock
branch
from
5add67f to
20f872b
Compare
|
Hey @brianjmurrell, Cheers! |
|
Changes look fine and work here in the tests I ran on them. |
To facilitate building with mock allow specifying the mock "root" to build in. Allow specifying the kernel version to build for. Signed-off-by: Brian J. Murrell <brian@interlinx.bc.ca>
Signed-off-by: Rafal Stefanowski <rafal.stefanowski@huawei.com>
Signed-off-by: Rafal Stefanowski <rafal.stefanowski@huawei.com>
- add --kernel-version option - add --mock option for 'mock' support to emulate building RPM packages on other distros to further improve choosing proper kernel version - update dependencies Signed-off-by: Rafal Stefanowski <rafal.stefanowski@huawei.com>
rafalste
force-pushed
the
build-rpm-with-mock
branch
from
20f872b to
0585797
Compare
|
Any further reviews required here or can this be landed? |
5 participants
To facilitate building with mock allow specifying the mock "root" to build in.
Allow specifying the kernel version to build for.