Skip to content

Fix involuntary preemption check #1678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robertbaldyga merged 1 commit into from
Aug 26, 2025
Merged

Fix involuntary preemption check #1678

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 15 additions & 13 deletions modules/cas_cache/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,22 +45,15 @@ struct cas_module cas_module;

static inline uint32_t involuntary_preemption_enabled(void)
{
bool config_dynamic = IS_ENABLED(CONFIG_PREEMPT_DYNAMIC);
bool config_rt = IS_ENABLED(CONFIG_PREEMPT_RT);
bool config_preempt = IS_ENABLED(CONFIG_PREEMPT);
bool config_lazy = IS_ENABLED(CONFIG_PREEMPT_LAZY);
bool config_none = IS_ENABLED(CONFIG_PREEMPT_NONE);

if (!config_dynamic && !config_rt && !config_preempt && !config_lazy)
return false;

if (config_none)
return false;

if (config_rt || config_preempt || config_lazy) {
if (config_rt) {
printk(KERN_ERR OCF_PREFIX_SHORT
"The kernel has been built with involuntary preemption "
"enabled.\nFailed to load Open CAS kernel module.\n");
"The kernel has been compiled with real-time "
"preemption enabled (PREEMPT_RT).\nFailed to load "
"Open CAS kernel module");
return true;
}

Expand All @@ -78,11 +71,20 @@ static inline uint32_t involuntary_preemption_enabled(void)
"preemption enabled.\nFailed to load Open CAS kernel "
"module.\n");
return true;
} else {
return false;
}
return false;

#endif

if (config_preempt || config_lazy) {
printk(KERN_ERR OCF_PREFIX_SHORT
"The kernel has been compiled with involuntary "
"preemption enabled.\nFailed to load Open CAS kernel "
"module.\n");
return true;
}


return false;
}

Expand Down