Skip to content

Use separate callback for core detach #1684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robertbaldyga merged 2 commits into from
Sep 15, 2025
Merged

Use separate callback for core detach #1684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d2a831
Update OCF
Sep 15, 2025
b9b6784
Use separate callback for core detach
Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions modules/cas_cache/layer_cache_management.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1482,6 +1482,12 @@ static void _cache_mngt_generic_complete(void *priv, int error)
complete(&context->cmpl);
}

static void _cache_mngt_detach_core_complete(ocf_core_t core, void *priv,
int error)
{
_cache_mngt_generic_complete(priv, error);
}

static void _cache_mngt_remove_core_fallback(ocf_cache_t cache, ocf_core_t core)
{
struct _cache_mngt_sync_context context;
Expand All @@ -1495,7 +1501,7 @@ static void _cache_mngt_remove_core_fallback(ocf_cache_t cache, ocf_core_t core)
context.result = &result;

ocf_mngt_cache_detach_core(core,
_cache_mngt_generic_complete, &context);
_cache_mngt_detach_core_complete, &context);

wait_for_completion(&context.cmpl);

Expand Down Expand Up @@ -1568,7 +1574,7 @@ int cache_mngt_remove_core_from_cache(struct kcas_remove_core *cmd)

if (cmd->detach) {
ocf_mngt_cache_detach_core(core,
_cache_mngt_generic_complete, &context);
_cache_mngt_detach_core_complete, &context);
} else {
ocf_mngt_cache_remove_core(core,
_cache_mngt_generic_complete, &context);
Expand Down
2 changes: 1 addition & 1 deletion ocf
Open in desktop
Submodule ocf updated 6 files
+11 −1 inc/ocf_cache.h
+4 −2 inc/ocf_mngt.h
+11 −10 src/mngt/ocf_mngt_core.c
+6 −0 src/ocf_cache.c
+1 −1 tests/functional/pyocf/types/core.py
+2 −2 tests/functional/run_with_sanitizers.sh
Loading