Skip to content

Conversation

@brondani
Copy link
Collaborator

@brondani brondani commented Feb 7, 2025

Fixes

Changes

  • Set CMake GENERATED property of source files expected to be created by executes
  • Add further golden references of executes test cases

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

Test Results

  4 files  ±0   20 suites  ±0   1s ⏱️ ±0s
 75 tests +1   75 ✅ +1  0 💤 ±0  0 ❌ ±0 
300 runs  +4  300 ✅ +4  0 💤 ±0  0 ❌ ±0 

Results for commit 98df6c6. ± Comparison against base commit 29836b8.

♻️ This comment has been updated with latest results.

@brondani brondani force-pushed the cbuild2cmake-set-generated-files-property branch from 973049a to 98df6c6 Compare February 7, 2025 17:20
@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 98df6c6 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 83.3% (50% is the threshold).

This pull request will bring the total coverage in the repository to 88.0% (0.0% change).

View more on Code Climate.

@brondani brondani marked this pull request as ready for review February 7, 2025 17:35
@brondani brondani requested a review from soumeh01 February 7, 2025 17:35
@brondani brondani merged commit e1f25dd into main Feb 11, 2025
17 checks passed
@brondani brondani deleted the cbuild2cmake-set-generated-files-property branch February 11, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants