Skip to content

Conversation

@brondani
Copy link
Collaborator

@brondani brondani commented Jul 7, 2025

Fixes

Changes

  • For image-only solutions, generate an executes-only CMakeLists.txt

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@brondani brondani force-pushed the cbuild2cmake-add-support-image-only branch 2 times, most recently from 93ad99d to 54b1f51 Compare July 7, 2025 15:42
@brondani brondani force-pushed the cbuild2cmake-add-support-image-only branch from 54b1f51 to 376d905 Compare July 7, 2025 15:49
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2025

Test Results

  4 files  ± 0   20 suites  ±0   2s ⏱️ ±0s
 78 tests + 3   78 ✅ + 3  0 💤 ±0  0 ❌ ±0 
312 runs  +12  312 ✅ +12  0 💤 ±0  0 ❌ ±0 

Results for commit 376d905. ± Comparison against base commit 61a469f.

@qltysh
Copy link

qltysh bot commented Jul 7, 2025

Diff Coverage: The code coverage on the diff in this pull request is 85.4%.

Total Coverage: This PR will increase coverage by 0.01%.

File Coverage Changes
Path File Coverage Δ Indirect
pkg/maker/maker.go -1.0
pkg/maker/parser.go 1.9
pkg/maker/superlists.go 0.4
🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@brondani brondani marked this pull request as ready for review July 7, 2025 15:53
@brondani brondani requested a review from soumeh01 July 7, 2025 15:53
Copy link
Collaborator

@soumeh01 soumeh01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brondani brondani merged commit 2c38fc2 into main Jul 8, 2025
19 checks passed
@brondani brondani deleted the cbuild2cmake-add-support-image-only branch July 8, 2025 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants