Skip to content

Conversation

@brondani
Copy link
Collaborator

@brondani brondani commented Dec 11, 2025

Changes

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@brondani brondani force-pushed the update-performance-reference branch from 161d56f to a3d65e8 Compare December 11, 2025 09:59
@brondani brondani force-pushed the update-performance-reference branch from a3d65e8 to a504885 Compare December 11, 2025 10:10
@brondani brondani changed the title Update tag for performance tests reference Set performance tests threshold to 20% Dec 11, 2025
@brondani brondani marked this pull request as ready for review December 11, 2025 10:27
@brondani brondani requested a review from jkrech December 11, 2025 10:27
Copy link
Member

@jkrech jkrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acceptable for the moment. @soumeh01 to investigate when he is back.

@jkrech jkrech merged commit a4e9ab6 into main Dec 11, 2025
13 checks passed
@jkrech jkrech deleted the update-performance-reference branch December 11, 2025 11:21
@soumeh01 soumeh01 mentioned this pull request Dec 22, 2025
5 tasks
soumeh01 added a commit that referenced this pull request Dec 22, 2025
## Fixes
- Addressing #478

## Changes
- Performance tests threshold needed to be revereted back from 20% to
10%
- In order to cater this change, created a new test reference tag
[2.12.0-test-reference](https://github.com/Open-CMSIS-Pack/cmsis-toolbox/releases/tag/2.12.0-test-reference)
with updated reference toolbox

## Checklist
<!-- Put an `x` in the boxes. All tasks must be completed and boxes
checked before merging. -->
- [ ] 🤖 This change is covered by unit tests (if applicable).
- [ ] 🤹 Manual testing has been performed (if necessary).
- [x] 🛡️ Security impacts have been considered (if relevant).
- [ ] 📖 Documentation updates are complete (if required).
- [ ] 🧠 Third-party dependencies and TPIP updated (if required).
@soumeh01
Copy link
Collaborator

soumeh01 commented Dec 22, 2025

@brondani @jkrech The threshold is reverted back to 10% with new test reference in #486

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants