Skip to content

omit empty timestamp#422

Merged
bgn42 merged 1 commit intomainfrom
emptyTimestamp
Jan 17, 2025
Merged

omit empty timestamp#422
bgn42 merged 1 commit intomainfrom
emptyTimestamp

Conversation

@bgn42
Copy link
Collaborator

@bgn42 bgn42 commented Jan 16, 2025

Fixes

#421

Changes

added omitempty to timestamp tag

Checklist

  • 🤖 This change is covered by unit tests as required.
  • 🤹 All required manual testing has been performed.
  • 🛡️ Security impacts have been considered.
  • 📖 All documentation updates are complete.
  • 🧠 This change does not change third-party dependencies

@bgn42 bgn42 requested a review from DavidLesnjak January 16, 2025 15:44
@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 679d6c7 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.9% (0.0% change).

View more on Code Climate.

@bgn42 bgn42 requested a review from JonatanAntoni January 17, 2025 09:40
Copy link
Member

@JonatanAntoni JonatanAntoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Mac and works as expected.

@bgn42 bgn42 merged commit d4bc1c6 into main Jan 17, 2025
17 checks passed
@bgn42 bgn42 deleted the emptyTimestamp branch January 17, 2025 09:50
@DavidLesnjak
Copy link

I tested on Win11 and also works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants